Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe user from shifts on user account deletion #516

Conversation

pitpalme
Copy link
Contributor

When user requests account deletion and still subscribed to future shifts,
this subscription is removed, so slot is free for reuse.
Fixes #477.

@christophmeissner
Copy link
Contributor

Shower thought: in order to avoid being forced to tear down everything, the user ever was involved with, I was thinking about just setting UserAccount.user to NULL for deleted users and treat those objects as deleted users. However, this should work for now, we can rethink handling deleted users later on.

When user requests account deletion and still subscribed to future shifts,
this subscription is removed, so slot is free for reuse.
Fixes coders4help#477.
Let black define format and try to make flake8 happy.
@christophmeissner christophmeissner force-pushed the feature/unsub_account_from_shift_on_deletion branch from 22581e8 to 10d0594 Compare March 24, 2022 16:11
@christophmeissner christophmeissner merged commit 78726c8 into coders4help:develop Mar 24, 2022
@pitpalme pitpalme deleted the feature/unsub_account_from_shift_on_deletion branch March 24, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted account is not unsubscribed from shift
2 participants