Support dependencies with node_modules folders in them

[tay1orjones]

🐛 bug report

Description of the problem

I receive the error

ModuleNotFoundError
Could not find module in path: 'carbon-addons-iot-react/es/node_modules/carbon-components-react/es/prop-types/types.js' relative to '/node_modules/carbon-addons-iot-react/es/src/components/Button/Button.jsx'

Despite this being available at the location indicated.

Here's a screencap of our build output for carbon-addons-iot-react

Additionally you can see the file is available at this location in our package in unpkg
https://unpkg.com/carbon-addons-iot-react@2.93.5/es/node_modules/carbon-components-react/es/prop-types/types.js

How has this issue affected you? What are you trying to accomplish?

This prevents us from using codesandbox as a bug reporting and example code tool.

Link to sandbox: https://codesandbox.io/s/objective-darkness-r8xzc?file=/src/index.js

Your Environment

Software	Name/Version
Сodesandbox	015cbaa (this was in the bottom left corner of the page)
Browser	Chrome
Operating System	MacOS

[tay1orjones]

@cowills @mhewson should #709 have fixed this? The error is still present in the linked sandbox above.

[cowills]

@cowills @mhewson should #709 have fixed this? The error is still present in the linked sandbox above.

Nope, we just fixed the issue in our codebase by switching to a different bundle of our library.

[tay1orjones]

Ah! My mistake - I didn't realize the PR was in your codebase and not in codesandbox 🤦

[CompuIves]

Oh yes, this is interesting. The fact that it includes /node_modules confuses the bundler I think, and makes it look on unpkg to find whether the file exists... Doing a deeper dive now.

[CompuIves]

Yes, that's the case. The challenge here is that the in-browser bundler has an incomplete view on all files that are available, and because of this it has to make some assumptions when it can't find a file. If there's a file missing in node_modules, it tries to resolve a package.json and resolve the appropriate file from unpkg. I think that's where this goes wrong, because in this case it can't find the right version on unpkg.

[CompuIves]

The best solution would be to start saving paths for dependencies, as this would remove the whole guessing part. It would require us to regenerate the dependency cache for this, but other than that it seems like a sensible choice to me,

[github-actions]

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[CompuIves]

Keeping this one open since the saving paths feature is still something that's in the planning.

[github-actions]

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[github-actions]

This issue has been automatically closed because there wasn't any activity after the previous notice or the stale label wasn't removed.

[apsamuel]

This is still an issue

[CompuIves]

Will reopen this one, and also rename the title a bit because we've narrowed the scope on this one. For what sandbox do you have this issue @apsamuel ?

[apsamuel]

Will reopen this one, and also rename the title a bit because we've narrowed the scope on this one. For what sandbox do you have this issue @apsamuel ?

apologies for the delay - https://codesandbox.io/s/dme0w, I emailed out to codesandbox team and was informed there may have been an infrastructure issue on that specific occasion

[github-actions]

This issue has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

[shaoster]

Willing to take any PRs for this? Looks like anything that transitively depends on socket.io hits this now: https://github.com/socketio/engine.io-client/blob/9eeed5e0c0a3a3598d27947dabc57b47ca3a8365/lib/transports/index.js#L1.

See the package.json inclusion of (4.0.0): https://codesandbox.io/s/boardgameio-tutorial-setup-zgrsc?from-embed=&file=/package.json:259-290.

[CompuIves]

Interesting case, it looks like in the case you mentioned the require to XMLHTTPrequest is not in a node modules directory so it should work. But I should check closer, we can do that on Monday or Tuesday! cc @DeMoorJasper

[shaoster]

I think the ../.. prefix resolves to a node_modules rooted dir.

From the repro above:

[jsjoeio]

I'm running into this issue with this CodeSandbox

Seems like some other folks are experiencing this and opened an issue in socket-io-client

[CompuIves]

Right, that should not happen. I'll make sure that we take a look at this this week and come with a solution!