fix cdr-tokens import in sandbox #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed the sandboxes currently load with an error because the cdr-tokens dep disappeared, this will fix the CSS side of that error
there is another unrelated JS bug in codesandbox that causes a different cdr-tokens related error codesandbox/codesandbox-client#4456
seems like codesandbox might be excluding anything named "node_modules" from the bundle it creates, which excludes the mini copy of cdr-tokens that we bundle into our ESM:
We can bypass that by forcing the sandbox to import from
cedar.mjswhich is the un-tree-shakeable ESM bundle, as that bundle simply inlines the cdrTokens: