Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community templates #709

Merged
merged 24 commits into from
Apr 25, 2018
Merged

Community templates #709

merged 24 commits into from
Apr 25, 2018

Conversation

CompuIves
Copy link
Member

This is a combination of #665 and #683. I'm using this to see the complete diff and do testing. I will deploy this to staging too 😄

@CompuIves
Copy link
Member Author

cc @nicknisi and @mstijak. I think it would be great if both templates would be based of a GitHub repository. Then I'll change the logic of the importer to detect CxJS and Dojo so we can do final proper testing on staging.

@nicknisi
Copy link
Contributor

nicknisi commented Apr 8, 2018

@CompuIves Cool! The Dojo template lives at https://github.com/dojo/dojo-codesandbox-template.

@CompuIves
Copy link
Member Author

Great! I'll let the importer use the dojo template if it detects @dojo/core in the project dependencies. Does that make sense @nicknisi?

@nicknisi
Copy link
Contributor

nicknisi commented Apr 8, 2018

Yeah, that makes sense!

@mstijak
Copy link
Contributor

mstijak commented Apr 9, 2018

@CompuIves The CxJS template is available at https://github.com/codaxy/cxjs-codesandbox-template. It should be enough to detect cx package dependency. Please note that react will also be listed in dependencies as CxJS uses React for rendering.

@nicknisi
Copy link
Contributor

nicknisi commented Apr 13, 2018

@CompuIves Any ideas on when you might be planning to merge this? Not trying to rush at all, just trying to get an understanding of your timeline!

@CompuIves
Copy link
Member Author

I've put everything on staging now! I'm planning to merge it today.

If you're interested in helping with testing, send your IP to me via Discord or something, I'll add you to the whitelist on our staging server 😄

@CompuIves
Copy link
Member Author

Did a bunch of testing, looks good! One thing I'm worrying a bit about is the amount of cubes on the homepage. I'm going to do a code review now and decide about the cubes after that. But it's definitely certain that we'll have this live today! 🎉

@CompuIves
Copy link
Member Author

Okay! Everything is ready to merge in after the checks are green and ready to deploy. I decided to keep the cubes on the homepage, but will probably remove some cubes in 2 days after the initial announcement. The reason for this is that every cube takes quite a lot of performance (5 big box-shadows per cube, with transforms) and I'm afraid that our bounce rate will increase if we make it very hefty.

Planning to use this GIF for the announcement:

cx-dojo-xs-small

But bigger of course 😄

@CompuIves CompuIves merged commit 7a26738 into master Apr 25, 2018
CompuIves added a commit that referenced this pull request Apr 25, 2018
* Add CxJS template UI

* Configure Babel for CxJS template

* Load transform-cx-jsx on demand

* Removing direct sharp dependency

* Update CxJS template

* add Dojo 2 as a preset template

- add dojo2 template
- add temporary project as template to load (github)
- add type definition creation to styles transpiler
- add dojo 2 to home page
- add default loading of dojo template src/index.html and src/main.css

* change dojo template url to dojo codesandbox repo

* add in temporary API override -- REMOVE COMMIT

* set isTypeScript to true for dojo template

* remove DojoIcon from dojo template definition

* Don't throw error for cxjs if main.css is not found

* Remove force of Dojo

* Fix check

* Update URLs

* Add CxJS to homepage

* update yarn.lock

* Add CxJS cube to the homepage and fix CxJS and Dojo icons (#751)

* Force build

* Change logo order for consistency with homepage

* Clean up transpilation listener on unmount

* Add to changelog

Co-authored-by: Marko Stijak <mstijak@gmail.com>
Co-authored-by: Nick Nisi <nick@nisi.org>
@SaraVieira SaraVieira deleted the community-templates branch May 14, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants