CxJS template #683
Closed
CxJS template #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, is this based on the recent changes I did on master? |
|
Yes, it is. Icon was removed from template registration and it took me some
time to discover that after rebasing.
…On Sun, Apr 1, 2018, 19:00 Ives van Hoorne ***@***.***> wrote:
Ah, is this based on the recent changes I did on master?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAac8m0ipIiznVMeW2fEIv_Q01sJreKgks5tkQeQgaJpZM4TCzFp>
.
|
|
Ah yes, I'm sorry for that! Great to see another template! I'm planning on merging the new templates (Dojo 2 and CxJS) in this Thursday. |
|
Great. The only issue I see is with creating a new sandbox. Is that something that you'll handle? Do you need a "Hello World" sample for CxJS? |
Merged
|
It's in! :D |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a new template for CxJS (#628)
What is the current behavior?
What is the new behavior?
Checklist:
It took me a while, but it actually wasn't that hard. Please let me know what's the next step.