/app/pages/common/Modals/PreferencesModal/Badges/index.js 🔨 Refactor 🧠 Overmind Hacktoberfest #2760
Conversation
refactored the badges index.js file to use overmind and added named export instead of default export
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codesandbox/codesandbox-client/9jik58ugm |
Sowmiya07
changed the title
Sowmiya07
changed the title
|
@Sowmiya07 I think this is failing because of lint error. Maybe try running |
Saeris
added
Hacktoberfest
🔨 Refactor
🧠 Overmind
| @@ -1,12 +1,20 @@ | |||
| import React from 'react'; | |||
| import { inject, observer } from 'app/componentConnectors'; | |||
| import React, {FunctionComponent} from 'react'; | |||
There was a problem hiding this comment.
| import React, {FunctionComponent} from 'react'; | |
| import React from 'react'; |
For types we don't need to use named imports, we can just pull it off React
|
|
||
| import Margin from '@codesandbox/common/lib/components/spacing/Margin'; | ||
| import Badge from '@codesandbox/common/lib/utils/badges/Badge'; | ||
| import { Title } from '../elements'; | ||
|
|
||
| function BadgesComponent({ store, signals }) { | ||
| const badgesCount = store.user.badges.length; | ||
| export const Badges: FunctionComponent = () => { |
There was a problem hiding this comment.
| export const Badges: FunctionComponent = () => { | |
| export const Badges: React.FC = () => { |
| export const Badges: FunctionComponent = () => { | ||
| const { | ||
| state: { | ||
| user: {badges}, |
There was a problem hiding this comment.
| user: {badges}, | |
| user: { badges }, |
eslint --fix should have caught this, not sure why it didn't. Adding spaces for consistency
| user: {badges}, | ||
| }, | ||
| actions: { | ||
| preferences: {setBadgeVisibility}, |
There was a problem hiding this comment.
| preferences: {setBadgeVisibility}, | |
| preferences: { setBadgeVisibility }, |
There was a problem hiding this comment.
Looks great! Made a few change requests suggesting stylistic changes for consistency with the rest of the code base. Could you add them all to a batch and commit them? You can do that from the files tab. I'd do it myself but I can't commit to your fork. Thanks for the submission!
|
Thank you for your help! |
Refactored the badges index.js file to use overmind and added named export instead of default export
What kind of change does this PR introduce?
This is part of the requested refactor for hacktoberfest mentioned in #2760
@Saeris @christianalfoni
What is the current behavior?
Previously it was utilizing inject and hooksObserver from app/componentConnectors.
What is the new behavior?
Prefers useOvermind over inject and other small stylistic choices mentioned in #2760
What steps did you take to test this? This is required before we can merge.
yarn:lint: I was not able to do this as I have some errors doing yarn
yarn:test: I was not able to do this as I have some errors doing yarn
Checklist