Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Switch Badges to use useOvermind #3072

Merged
merged 1 commit into from
Nov 28, 2019
Merged

🔨 Switch Badges to use useOvermind #3072

merged 1 commit into from
Nov 28, 2019

Conversation

MichaelDeBoey
Copy link
Contributor

Follow-up of #2760

Things I did extra:

  • Change setBadgeVisibility's signature to get its argument types directly from Badge instead of hardcoding them
  • Just use badges.length instead of an extra badgesCount variable
  • Simplify Badge's onClick prop a bit

@MichaelDeBoey MichaelDeBoey added 🔨 Refactor 🧠 Overmind Indicates that this is related to the app's State Management labels Nov 22, 2019
@lbogdan
Copy link
Contributor

lbogdan commented Nov 22, 2019

Build for latest commit 7da3616 is at https://pr3072.build.csb.dev/s/new.

christianalfoni
christianalfoni approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@christianalfoni christianalfoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😄 👍

Tested:

  • Open badges in preferences
  • Toggled it and refreshed, it saves
  • Double checked it looks the same on codesandbox.io

@christianalfoni christianalfoni merged commit 99e2226 into codesandbox:master Nov 28, 2019
@MichaelDeBoey MichaelDeBoey deleted the overmind/Badges branch November 28, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianalfoni christianalfoni christianalfoni approved these changes

@SaraVieira SaraVieira Awaiting requested review from SaraVieira

Assignees
No one assigned
Labels
🧠 Overmind Indicates that this is related to the app's State Management 🔨 Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelDeBoey @lbogdan @christianalfoni