Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Comment glyphs #3726

Merged
merged 78 commits into from
Mar 27, 2020
Merged

WIP: Comment glyphs #3726

merged 78 commits into from
Mar 27, 2020

Conversation

christianalfoni
Copy link
Contributor

No description provided.

@lbogdan lbogdan temporarily deployed to pr3726 March 19, 2020 16:36 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Mar 19, 2020 •
edited
Loading

Build for latest commit 25e87da is at https://pr3726.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3726 March 20, 2020 13:32 Inactive
@lbogdan lbogdan temporarily deployed to pr3726 March 20, 2020 16:41 Inactive
@lbogdan lbogdan temporarily deployed to pr3726 March 20, 2020 22:53 Inactive
@christianalfoni
Copy link
Contributor Author

christianalfoni commented Mar 21, 2020 •
edited
Loading

I did some changes here:

  1. I refactored comments into its own namespace of Overmind
  2. Though the implementation of active glpyhs made perfect sense I moved it way back to where the glyphs are created, so it rather builds everything at the same spot
  3. Now you can select code and write a comment and it actually creates a comment 😮

@lbogdan lbogdan temporarily deployed to pr3726 March 21, 2020 15:32 Inactive
@siddharthkp siddharthkp mentioned this pull request Mar 23, 2020
Closed
siddharthkp and others added 21 commits March 26, 2020 12:58
@siddharthkp
found the missing 48px :P
034cb45
@siddharthkp
dont need to track animation state now
588f247
@siddharthkp
always div for unknown semantics
00edbaa
@siddharthkp
fix comment current target trigger
ff03379
@siddharthkp
omg strings!
49e4133
@christianalfoni
fix animations on comments
0c16af6
@christianalfoni
improve handling optimistic
937cf79
@christianalfoni
use animate controller
5979461
@christianalfoni
add comments
b4f0a94
@SaraVieira @christianalfoni
Add times and move file name (#3752)
0d830d2 
Co-authored-by: Christian Alfoni <christianalfoni@gmail.com>
@christianalfoni
fix issue with moving from optimistic to existing comment
9172472
@christianalfoni
refactor to initial and end position
aa44743
@christianalfoni
ensure we actually have a comments state for the sandbox
4a9ef03
@christianalfoni
fix multi popup
ef2e18b
@christianalfoni
auto focus on creating new comment
d48dd11
@christianalfoni
add permission checks on comments
e00b4f3
@siddharthkp
drag handle!!!
f172618
@christianalfoni
improve dragging
4f1eb58
@SaraVieira
style multi comments (#3763)
4154872 
* style multi comments

* use element

* update lookup
@christianalfoni
merge
24ec148
@christianalfoni
fix ot typing
6e9f632
@lbogdan lbogdan temporarily deployed to pr3726 March 27, 2020 14:42 Inactive
@lbogdan lbogdan temporarily deployed to pr3726 March 27, 2020 15:11 Inactive
@lbogdan lbogdan temporarily deployed to pr3726 March 27, 2020 15:54 Inactive
@christianalfoni christianalfoni merged commit e98ccf5 into master Mar 27, 2020
@christianalfoni christianalfoni deleted the comments-glyphs branch March 27, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christianalfoni @lbogdan @siddharthkp @SaraVieira