Comment transitions - first draft from sidebar #3729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for latest commit 5db4ae4 is at https://pr3729.build.csb.dev/s/new. |
siddharthkp
changed the title
siddharthkp
added a commit
that referenced
this pull request
Mar 23, 2020
|
Copied to #3726 |
christianalfoni
added a commit
that referenced
this pull request
Mar 27, 2020
* initial stuff * initial glyph implementation * optimistic transposing * add active class to glyphs * WIP: add comment from context * handling optimistic thread * multi comments on line * favor active over multi icon * add numbers * copy changes from #3729 * remove trigger check * remove react-draggable coz we have framer motino * open file and scroll to position * refactored most, continuing on laptop... * fix replies * glyph likes themes * oops that not supposed to be there * extract avatarblock * move edit comment out * use edit content in reply * add dialog positioning * always render even if position is not known * better fallback position * remove unused ref * add polling mechanism to active comment * change the fallback just a little more * optimistically set position * fix checking id in comment glyph boundary as well * remove optimistic trigger * improve moving comments * use currentTarget instead * set placeholder + animate from left in fallback * move position logic into a funktion * animate based on _file change_ * rename optimistic to newComment * add permalinks (#3744) * add permalinks * remove query from effect * move copy to clipboard to effect * add defaults * create action for commenturl * yaay * Apply suggestions from code review Co-Authored-By: Christian Alfoni <christianalfoni@gmail.com> * Update packages/app/src/app/pages/Sandbox/index.tsx Co-Authored-By: Christian Alfoni <christianalfoni@gmail.com> * make action Co-authored-by: Christian Alfoni <christianalfoni@gmail.com> * fixed add comment position and decorate line * redesign new comment * fix ... icon * pull out new comment component * rename to AddComment duh * move add reply to a component * pull out comment header * pull out comment body into a component * close dialog is lame * but i am lamer * leave a comment before i forget * add comment glyph * some fixes * window collisions - first draft * cheeky scale guessing * found the missing 48px :P * dont need to track animation state now * always div for unknown semantics * fix comment current target trigger * omg strings! * fix animations on comments * improve handling optimistic * use animate controller * add comments * Add times and move file name (#3752) Co-authored-by: Christian Alfoni <christianalfoni@gmail.com> * fix issue with moving from optimistic to existing comment * refactor to initial and end position * ensure we actually have a comments state for the sandbox * fix multi popup * auto focus on creating new comment * add permission checks on comments * drag handle!!! * improve dragging * style multi comments (#3763) * style multi comments * use element * update lookup * fix ot typing * fixed types and defaulting to comments * fix typing * last fixes Co-authored-by: Sara Vieira <hey@iamsaravieira.com> Co-authored-by: siddharthkp <siddharth.kshetrapal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animates from sidebar row
Missing elements:
Copied to #3726