[CRASH] No sale request

[benbierens]

Eth-archiver node crashes with the following error:

TRC 2025-06-01 19:02:50.704+00:00 Already connected                          topics="codex blockexcnetworkpeer" tid=1748516 peer=16U*3Ajvin connId=683ca34baaeb55e1c2b40218
TRC 2025-06-01 19:02:50.704+00:00 Sending message                            topics="codex blockexcnetworkpeer" tid=1748516 peer=16U*3Ajvin connId=683ca34baaeb55e1c2b40218
TRC 2025-06-01 19:02:50.705+00:00 Received message                           topics="codex blockexcnetworkpeer" tid=1748516 peer=16U*3Ajvin connId=683ca34baaeb55e1c2b40216
TRC 2025-06-01 19:02:50.705+00:00 Received want list from peer               topics="codex blockexcengine" tid=1748516 peer=16U*3Ajvin wantList=1
TRC 2025-06-01 19:02:50.706+00:00 Processing want list entry                 topics="codex blockexcengine" tid=1748516 wantList="(address: treeCid: zDzSvJTf8c45tDKbbYgnG2PuwzxV8eaGaU1RkJcNurBmPTkdb1v8, index: 7595, priority: 0, cancel: false, wantType: WantHave, sendDontHave: false, inFlight: false)" wantType=WantHave address="treeCid: zDz*kdb1v8, index: 7595" peer=16U*3Ajvin
TRC 2025-06-01 19:02:50.706+00:00 Sending presence to remote                 topics="codex blockexcengine" tid=1748516 items="(address: treeCid: zDzSvJTf8c45tDKbbYgnG2PuwzxV8eaGaU1RkJcNurBmPTkdb1v8, index: 7595, type: Have, price: @[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])"
TRC 2025-06-01 19:02:50.707+00:00 Already connected                          topics="codex blockexcnetworkpeer" tid=1748516 peer=16U*3Ajvin connId=683ca34baaeb55e1c2b40218
TRC 2025-06-01 19:02:50.707+00:00 Sending message                            topics="codex blockexcnetworkpeer" tid=1748516 peer=16U*3Ajvin connId=683ca34baaeb55e1c2b40218
WRN 2025-06-01 19:02:50.707+00:00 Cannot retrieve the request                topics="marketplace onchain market" tid=1748516 error="EVM reverted: Marketplace_UnknownRequest()"
ERR 2025-06-01 19:02:50.708+00:00 Unhandled exception in async proc, aborting topics="codex" tid=1748516 msg="no sale request"

Node was being used to upload and store eth ERA files.

Node is a custom build of v0.2.3 with 1 modification:

--- a/codex/purchasing/states/submitted.nim
+++ b/codex/purchasing/states/submitted.nim
@@ -32,7 +32,8 @@ method run*(
   proc wait() {.async.} =
     let done = newFuture[void]()
     proc callback(_: RequestId) =
-      done.complete()
+      if not done.completed():
+        done.complete()

     let subscription = await market.subscribeFulfillment(request.id, callback)
     await done

This is made in order to work around a different client mode crash: #962

[emizzle]

Hard to say exactly what the error is without more context, however "Cannot retrieve the request" (EVM reverted: Marketplace_UnknownRequest() means the request id that kicked off the sales state machine was not found in the contract. This either occurred in the SalePreparing or SaleUnknown states. The former would be a response to a SlotFreed or StorageRequested. The latter would be from a node restarting and reading its active slots from the contract, which already populates the request from the getActiveSlot contract call using the same request lookup as getRequest. That's makes me think it's unlikely to be in SaleUnknown and more likely to be occurring in SalePreparing.

Perhaps there is some way the node is getting request events for a request that is on the OLD contract? This seems almost impossible...

Could you post some more logs around which state this would have been logged from? And also which contract event was reacted to?

[markspanbroek]

Made a fix for the crash in #1248. Still doesn't explain why we get into this state, but at least the node will handle it now.