Skip to content

Conversation

markspanbroek
Copy link
Contributor

Fixes #1247

@emizzle
Copy link
Contributor

emizzle commented Jun 2, 2025

This is great, thank you Mark. I believe think this may be a partial fix for #1247. It'll prevent the node from crashing when a request cannot be found, but it doesn't address the root cause of why the request could not be found in the contract. Therefore, I'd be hesitant to close #1247 when merging this.

@markspanbroek
Copy link
Contributor Author

I looked through the nim and solidity code once more, but can't think of a reason why getting the storage request returns a Marketplace_UnknownRequest error after we just got an event about the same storage request, other than that the JSON-RPC node might be looking at old state. If Geth were to have a race condition in which it sends out the event just before updating the current state, then this could happen. I'm speculating here, but given that we've seen this error while running against a very old Geth, I don't really want to dig into that codebase to find out more.

@markspanbroek markspanbroek added this pull request to the merge queue Jun 4, 2025
Merged via the queue into master with commit 2dd436b Jun 4, 2025
18 checks passed
@markspanbroek markspanbroek deleted the fix-crash-request-fetch branch June 4, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CRASH] No sale request
4 participants