guardrails for posts with pending spam flags #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inks for anonymous users
|
I am aware that this adds to the code that depends on a name that came from a YAML (configuration) file, which is inherently a little fragile. If system code depends on a specific flag type, it would be better to bake that in. But reseeding that in prod now also seems a little scary, so since this is not the first case of this (we were already doing that), I don't want to try to do that as part of this PR. |
cellio
force-pushed
the
cellio/1381-nerf-spam-posts
branch
from
b0b1553 to
1e1bbea
Compare
|
The test failure is the intermittent SSL one. Rerunning via force-push didn't fix it, but I don't know what I need to do now. |
cellio
force-pushed
the
cellio/1381-nerf-spam-posts
branch
from
1e1bbea to
aaf0d64
Compare
ArtOfCode-
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a post has pending spam flags, warn logged-in users and suppress links for anonymous users. There are currently no exceptions for the status of the target user; should there be? (Does this allow someone to harass curators by decorating their posts with warnings until the flags get declined?)
Fixes #1381.