-
Notifications
You must be signed in to change notification settings - Fork 44
Support bindInterceptor[T1, T2] #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package net.codingwell.scalaguice; | ||
|
|
||
| import java.lang.annotation.ElementType; | ||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
|
|
||
|
|
||
| /** | ||
| * There is no support for runtime annotation in Scala, so far | ||
| * Java interfaces need to be used. | ||
| */ | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target(ElementType.METHOD) | ||
| public @interface AOP { | ||
|
|
||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,8 @@ | |
| */ | ||
| package net.codingwell.scalaguice | ||
|
|
||
| import org.scalatest.{Matchers, WordSpec} | ||
|
|
||
| import com.google.inject._ | ||
| import org.scalatest.{Matchers, WordSpec} | ||
|
|
||
| class ScalaModuleSpec extends WordSpec with Matchers { | ||
|
|
||
|
|
@@ -78,7 +77,7 @@ class ScalaModuleSpec extends WordSpec with Matchers { | |
| } | ||
|
|
||
| "allow binding with annotation using a type parameter" in { | ||
| import name.Named | ||
| import com.google.inject.name.Named | ||
| val module = new AbstractModule with ScalaModule { | ||
| def configure() = { | ||
| bind[A].annotatedWith[Named].to[B] | ||
|
|
@@ -123,6 +122,17 @@ class ScalaModuleSpec extends WordSpec with Matchers { | |
| twoStrings.first should be ("first") | ||
| twoStrings.second should be ("second") | ||
| } | ||
|
|
||
| "allow binding annotation interceptro" in { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo: interceptor |
||
| val module = new AbstractModule with ScalaModule { | ||
| def configure() = { | ||
| bind[Say].to[SayHi] | ||
| bindInterceptor[AOPI](methodMatcher = annotatedWith[AOP]) | ||
| } | ||
| } | ||
| val say = Guice.createInjector(module).getInstance(classOf[Say]) | ||
| say.hi("Bob") should be ("Hi Bob") | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer to see a test that checks that the interceptor intercepts an annotated method. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For bonus points, you're welcome to add a test with a class annotated with AOP. But by no means is that a requirement to merge this! |
||
| } | ||
|
|
||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend showing exactly the same use case as the one in java: