Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip test_work_stealing_on_scaling_up #351

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Sep 19, 2022

Let's try unskipping test_work_stealing_on_scaling_up since a possible fix has been deployed on Coiled (xref #336 (comment))

Closes #336

@jrbourbeau
Copy link
Member Author

Okay, looks like we're still running into issues with test_work_stealing_on_scaling_up. We're seeing

  +-------------+----------+-----------+----------+
  | Package     | client   | scheduler | workers  |
  +-------------+----------+-----------+----------+
  | dask        | 2022.9.1 | 2022.6.0  | 2022.6.0 |
  | distributed | 2022.9.1 | 2022.6.0  | 2022.6.0 |
  +-------------+----------+-----------+----------+

in CI still. cc @ntabris @shughes-uk for visibility

@shughes-uk
Copy link
Contributor

shughes-uk commented Sep 19, 2022 via email

@ian-r-rose
Copy link
Contributor

@shughes-uk
Copy link
Contributor

shughes-uk commented Sep 19, 2022

Package sync seems to be not enabled?

  with Cluster(
        name=test_name_uuid,
        n_workers=1,
        worker_vm_types=["t3.medium"],
        scheduler_vm_types=["t3.xlarge"],
        wait_for_workers=True,
    ) as cluster:

@ian-r-rose
Copy link
Contributor

Hah, right you are! Seems like it got caught up in a merge issue. I'll push here to verify

@jrbourbeau
Copy link
Member Author

Thanks @ian-r-rose. I totally missed that.

@shughes-uk what are your thoughts on adding a package_sync config value to coiled? That way we could easily say "Coiled, please always use package sync"

@shughes-uk
Copy link
Contributor

Thanks @ian-r-rose. I totally missed that.

@shughes-uk what are your thoughts on adding a package_sync config value to coiled? That way we could easily say "Coiled, please always use package sync"

Seems reasonable, i'll add it to the todo list

@ian-r-rose ian-r-rose merged commit aadc5b1 into main Sep 20, 2022
@jrbourbeau jrbourbeau deleted the unskip-test_work_stealing_on_scaling_up branch September 20, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_work_stealing_on_scaling_up failing
3 participants