Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip test_work_stealing_on_scaling_up #351

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Unskip test_work_stealing_on_scaling_up #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ab4685
Unskip test_work_stealing_on_scaling_up
jrbourbeau Sep 19, 2022
215a2b9
Package sync
Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/benchmarks/test_work_stealing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import time

import dask.array as da
import distributed
import numpy as np
import pytest
from coiled import Cluster
from dask import delayed, utils
from distributed import Client
from packaging.version import Version
from tornado.ioloop import PeriodicCallback


Expand All @@ -16,11 +18,10 @@ def test_trivial_workload_should_not_cause_work_stealing(small_client):
small_client.gather(futs)


# @pytest.mark.xfail(
# distributed.__version__ == "2022.6.0",
# reason="https://github.com/dask/distributed/issues/6624",
# )
@pytest.mark.skip("https://github.com/coiled/coiled-runtime/issues/336")
@pytest.mark.xfail(
Version(distributed.__version__) < Version("2022.6.1"),
reason="https://github.com/dask/distributed/issues/6624",
)
def test_work_stealing_on_scaling_up(
test_name_uuid, upload_cluster_dump, benchmark_all
):
Expand All @@ -30,6 +31,7 @@ def test_work_stealing_on_scaling_up(
worker_vm_types=["t3.medium"],
scheduler_vm_types=["t3.xlarge"],
wait_for_workers=True,
package_sync=True,
) as cluster:
with Client(cluster) as client:
with upload_cluster_dump(client, cluster), benchmark_all(client):
Expand Down