Skip to content

Conversation

@CarsonRoscoe
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe commented May 28, 2025

Description

CDP Env var naming has changed from v1 to v2 in the CDP SDK. As we're moving the repo over to using the latest version, we are also updating all the env var naming conventions along the way.

tl;dr: CDP_API_KEY_NAME -> CDP_API_KEY_ID and CDP_API_KEY_PRIVATE_KEY -> CDP_API_KEY_SECRET

Tests

Testing by randomly selecting CDP examples in both Typescript and Python to run, and confirming they are all running as expected.

Note

This knowingly breaks the next and mcp templates in the create-onchain-agent CLI locally. They will automatically be fixed once we do our next release on Friday. In the meantime, we are ignoring these templates from the turborepo so that it does not trip up our github actions.

(The break is that they rely on the new interface, but they install from the npm registry, so until the release is out, they are trying to use an interface that is not yet available)

Checklist

  • Added documentation to all relevant README.md files
  • Added a changelog entry

@CarsonRoscoe CarsonRoscoe marked this pull request as ready for review May 28, 2025 13:44
@CarsonRoscoe CarsonRoscoe requested a review from murrlincoln as a code owner May 28, 2025 13:44
@cb-heimdall
Copy link

cb-heimdall commented May 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions github-actions bot added documentation Improvements or additions to documentation action provider New action provider wallet provider New wallet provider example New example agent framework extension New framework extension typescript labels May 28, 2025
@CarsonRoscoe CarsonRoscoe changed the title Feat/rename cdp env vars Renamed CDP env vars to modern convention May 28, 2025
@CarsonRoscoe CarsonRoscoe requested a review from avidreder May 28, 2025 17:10
Copy link

@avidreder avidreder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonRoscoe CarsonRoscoe merged commit cd044db into main May 28, 2025
28 checks passed
@CarsonRoscoe CarsonRoscoe deleted the feat/rename-cdp-env-vars branch May 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action provider New action provider documentation Improvements or additions to documentation example New example agent framework extension New framework extension typescript wallet provider New wallet provider

Development

Successfully merging this pull request may close these issues.

3 participants