fix(wallet-sdk): increase minimum node version from 10 to 16.20 #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
fix-wallet-sdk-node-version
branch
4 times, most recently
from
66e6b5c to
704f5d0
Compare
The dependencies eth-block-tracker@7.1.0 and eth-json-rpc-filters both require nodejs v14 while the package manifest currently indicates support for v10. Support for nodejs v14 and lower seems to already have been dropped from coinbase-wallet-sdk in coinbase#932. This fixes that discrepancy by dropping indicated support for major nodejs versions 10-15,17,19.
legobeat
force-pushed
the
fix-wallet-sdk-node-version
branch
from
704f5d0 to
e1255dd
Compare
legobeat
changed the title
|
Is it work? |
|
hey @legobeat , we realized that the engines/node filed is actually unnecessary for our lib, so decided to remove it. |
|
closing it as it's addressed with #1030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello from MetaMask 👋
The dependencies
eth-block-tracker@7.1.0andeth-json-rpc-filtersboth require nodejs v14 while the package manifest currently indicates support for v10.Support for nodejs v14 and lower seems to already have been dropped from coinbase-wallet-sdk in #932.
This fixes that discrepancy by dropping indicated support for major nodejs versions 10-15,17,19.
How did you test your changes?
Ran tests locally