Convert repo into yarn workspace and move eslint to the root directory #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cb-jake
requested review from
bangtoven and
erin-at-work
and removed request for
bangtoven
cb-jake
changed the title
erin-at-work
approved these changes
Jul 12, 2023
legobeat
added a commit
to legobeat/coinbase-wallet-sdk
that referenced
this pull request
Sep 10, 2023
The dependencies eth-block-tracker@7.1.0 and eth-json-rpc-filters both require nodejs v14 while the package manifest currently indicates support for v10. Support for nodejs v14 and lower seems to already have dropped from coinbase-wallet-sdk in coinbase#932. This fixes that by dropping ndicated support for major nodejs versions 10-15,17,19.
legobeat
added a commit
to legobeat/coinbase-wallet-sdk
that referenced
this pull request
Sep 10, 2023
The dependencies eth-block-tracker@7.1.0 and eth-json-rpc-filters both require nodejs v14 while the package manifest currently indicates support for v10. Support for nodejs v14 and lower seems to already have dropped from coinbase-wallet-sdk in coinbase#932. This fixes that discrepancy by dropping indicated support for major nodejs versions 10-15,17,19.
legobeat
added a commit
to legobeat/coinbase-wallet-sdk
that referenced
this pull request
Sep 10, 2023
The dependencies eth-block-tracker@7.1.0 and eth-json-rpc-filters both require nodejs v14 while the package manifest currently indicates support for v10. Support for nodejs v14 and lower seems to already have been dropped from coinbase-wallet-sdk in coinbase#932. This fixes that discrepancy by dropping indicated support for major nodejs versions 10-15,17,19.
legobeat
added a commit
to legobeat/coinbase-wallet-sdk
that referenced
this pull request
Sep 10, 2023
The dependencies eth-block-tracker@7.1.0 and eth-json-rpc-filters both require nodejs v14 while the package manifest currently indicates support for v10. Support for nodejs v14 and lower seems to already have been dropped from coinbase-wallet-sdk in coinbase#932. This fixes that discrepancy by dropping indicated support for major nodejs versions 10-15,17,19.
bangtoven
pushed a commit
that referenced
this pull request
Feb 29, 2024
#932) * convert repo to yarn workspace * update readme to account for workspace configuration * cleanup * move eslint to top level * scaffold new directories * move eslint to top level directory * additional lint * favor top level eslint over local * fix testing types * CodeQL check * clean up pkgs * modify node version * drop 14.x in favor of 20.x
bangtoven
pushed a commit
that referenced
this pull request
Aug 16, 2024
#932) * convert repo to yarn workspace * update readme to account for workspace configuration * cleanup * move eslint to top level * scaffold new directories * move eslint to top level directory * additional lint * favor top level eslint over local * fix testing types * CodeQL check * clean up pkgs * modify node version * drop 14.x in favor of 20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test your changes?