Generate binaries #121
Generate binaries #121
Conversation
Pull Request Test Coverage Report for Build 4311
💛 - Coveralls |
| @@ -379,6 +379,7 @@ Global Flags: | |||
| * `make test` to run tests | |||
| * `make lint` to lint the source code (included generated code) | |||
| * `make release` to run one last check before opening a PR | |||
| * `make compile version=RELEASE_TAG` to generate binaries | |||
There was a problem hiding this comment.
Would you mind adding a small section to the README about using binaries and that a script is in progress?
There was a problem hiding this comment.
You may want to add that it is a known issue to click download on the release:
hashicorp/terraform#23033
There was a problem hiding this comment.
Turns out curl bypasses this:
curl -L https://github.com/coinbase/rosetta-cli/releases/download/v0.4.1/rosetta-cli-0.4.1-darwin-10.6-amd64 -o rosetta-cli; chmod +x rosetta-cli;
There was a problem hiding this comment.
You may want to include this in the README ^^ with a warning to not download on the UI
| ``` | ||
| go get github.com/coinbase/rosetta-cli | ||
| ``` | ||
|
|
||
| To download the binary directly, run: | ||
| ``` | ||
| curl -L https://github.com/coinbase/rosetta-cli/releases/download/v0.4.1/rosetta-cli-0.4.1-darwin-10.6-amd64 -o rosetta-cli; chmod +x rosetta-cli; |
There was a problem hiding this comment.
You may want to do a rosetta-cli-{YOUR REQUIRED VERSION HERE}
README.md
Outdated
| ``` | ||
| go get github.com/coinbase/rosetta-cli | ||
| ``` | ||
|
|
||
| To download the binary directly, run: |
README.md
Outdated
| @@ -29,10 +29,18 @@ Before diving into the CLI, we recommend taking a look at the Rosetta API Docs: | |||
| * [Construction API](https://www.rosetta-api.org/docs/construction_api_introduction.html) | |||
|
|
|||
| ## Install | |||
| To install `rosetta-cli` by getting the source code, run: | |||
There was a problem hiding this comment.
not: To install rosetta-cli from source, run:
README.md
Outdated
| ``` | ||
| go get github.com/coinbase/rosetta-cli | ||
| ``` | ||
|
|
||
| To download a binary directly for MacOS, run: |
There was a problem hiding this comment.
Do we want to list installs for each OS? I was thinking do:
rosetta-cli-{YOUR REQUIRED VERSION HERE}-{YOUR OS HERE}
And then include a link to releases to identify
And then say, for example on mac with version 0.4.1:
curl -L https://github.com/coinbase/rosetta-cli/releases/download/v0.4.1/rosetta-cli-0.4.1-darwin-10.6-amd64 -o rosetta-cli; chmod +x rosetta-cli;
| @@ -49,6 +49,9 @@ salus: | |||
|
|
|||
| release: add-license shorten-lines format test lint salus | |||
|
|
|||
| compile: | |||
| xgo --targets=darwin/*,windows/*,linux/* -out bin/rosetta-cli-$(version) . | |||
There was a problem hiding this comment.
Is it possible to specify a tag here or do we need to checkout the code we want to compile @juliankoh ?
There was a problem hiding this comment.
This builds the code locally (as you can see from the . )
We can also build a specific tag but that would be a different command.
Motivation
Generate binaries to avoid having to compile manually.
Solution
make compilecommand to compile for windows, linux and darwin.Open questions