chore: Swap Settings Slippage fast follow #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Zizzamia
reviewed
Sep 3, 2024
| const SLIPPAGE_SETTINGS = { | ||
| AUTO: 'Auto', | ||
| CUSTOM: 'Custom', | ||
| }; |
Zizzamia
reviewed
Sep 3, 2024
| @@ -65,23 +70,22 @@ export function SwapSettingsSlippageInput({ | |||
| )} | |||
| > | |||
| <legend className="sr-only">Slippage Setting</legend> | |||
| {slippageSettings.map((slippageSetting) => ( | |||
| {Object.values(SLIPPAGE_SETTINGS).map((setting) => ( | |||
There was a problem hiding this comment.
setting is still a odd word, but I am going to approve it this for now.
Zizzamia
reviewed
Sep 3, 2024
| type="button" | ||
| className={cn( | ||
| pressable.default, | ||
| color.foreground, | ||
| 'flex-1 rounded-lg px-3 py-1 font-medium text-sm transition-colors', | ||
| isAutoSlippageSetting === (slippageSetting === 'Auto') | ||
| // Highlight the button if it is selected |
Zizzamia
reviewed
Sep 3, 2024
| @@ -90,7 +94,7 @@ export function SwapSettingsSlippageInput({ | |||
| background.default, | |||
| border.defaultActive, | |||
| 'flex h-9 w-24 items-center justify-between rounded-lg border px-2 py-1', | |||
| isAutoSlippageSetting && 'opacity-50', | |||
| slippageSetting === SLIPPAGE_SETTINGS.AUTO && 'opacity-50', | |||
There was a problem hiding this comment.
Must be the performance perfectionist in me :)
But everytime you have code that is writtend 2+ times, it cost CPU time. No big deal, but when you see those things, you can just write something like
let isSlippageSettingAuto = false;
useEffect(() => {
isSlippageSettingAuto = slippageSetting === SLIPPAGE_SETTINGS.AUTO;
}, [slippageSetting]);
and just use isSlippageSettingAuto evreywher. And make the code more elegant and also more efficient.
Zizzamia
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?