Test for executable concerns with dup only for String #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a more refined fix for being able to invoke a workflow by name (#123, originally fixed in #128) that also allows workflows using Sorbet to be declared final (fixing #178). The object is now only dup'd before calling
.singleton_classif it's aString.Testing
Existing tests for starting workflows continue to pass (as do all other tests):
I've also tested that,
executemethod are marked as final works without a runtime error. A test for this cannot be checked in without taking a new dependency on the Sorbet runtime. Code that I used to test this can be found at https://gist.github.com/jeffschoner/588ffec227506de7a8cd23d71889c42e