Skip to content

Test for executable concerns with dup only for String #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeRauk merged 1 commit into from
Feb 27, 2023
Merged

Test for executable concerns with dup only for String #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/temporal/execution_options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,21 @@ def task_list
private

def has_executable_concern?(object)
# NOTE: When object is a String .dup is needed since Object#singleton_class mutates
# it and screws up C extension class detection (used by Protobufs)
object.dup.singleton_class.included_modules.include?(Concerns::Executable)
if object.is_a?(String)
# NOTE: When object is a String, Object#singleton_class mutates it and
# screws up C extension class detection used in older versions of
# the protobuf library. This was fixed in protobuf 3.20.0-rc1
# via https://github.com/protocolbuffers/protobuf/pull/9342.
#
# Creating a duplicate of this object prevents the mutation of
# the original object which will be put into a protobuf payload
# before being sent to Temporal server. Because duplication fails
# when Sorbet final classes are used, duplication is limited only
# to String classes.
object = object.dup
end

object.singleton_class.included_modules.include?(Concerns::Executable)
rescue TypeError
false
end
Expand Down