Skip to content

Conversation

@0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Nov 20, 2025

Description

fetch's request init param is optional.

Tests

This was tested by building the package and installing into a standalone app with the following code:

import { useX402 } from "@coinbase/cdp-hooks";

const { fetchWithPayment } = useX402();
const response = await fetchWithPayment(resourceUrl);

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@cb-heimdall
Copy link

cb-heimdall commented Nov 20, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
x402 Ready Ready Preview Comment Nov 20, 2025 6:39pm

@0xRAG 0xRAG requested a review from CarsonRoscoe November 20, 2025 18:43
@cb-heimdall
Copy link

Review Error for CarsonRoscoe @ 2025-11-20 18:52:50 UTC
User failed mfa authentication, see go/mfa-help

Copy link

@avidreder avidreder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonRoscoe CarsonRoscoe merged commit ead3446 into main Nov 20, 2025
20 checks passed
@juchiast juchiast mentioned this pull request Dec 18, 2025
3 tasks
phdargen added a commit to phdargen/x402 that referenced this pull request Dec 30, 2025
CarsonRoscoe pushed a commit that referenced this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants