Skip to content

Conversation

@phdargen
Copy link
Contributor

@phdargen phdargen commented Dec 30, 2025

Description

A collection of fixes for the v2 fetch client:

Tests

📊 Test Summary
==============
✅ Passed: 2
❌ Failed: 0
📈 Total: 2

📋 Detailed Test Results
========================

✅ PASSED TESTS:

  # 1: fetch → express → /protected
      Facilitator: typescript | Network: eip155:84532 | Tx: 0x5060992a...
  # 2: fetch → express → /protected-svm
      Facilitator: typescript | Network: solana:EtWTRABZaYq6iMfeYKouRu166VU2xqa1 | Tx: LKzj1HZaH3...

📊 Breakdown by Facilitator:
   typescript      ✅ 2 / ❌ 0 (100%)

📊 Breakdown by Server:
   express              ✅ 2 / ❌ 0 (100%)

📊 Breakdown by Client:
   fetch                ✅ 2 / ❌ 0 (100%)

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@cb-heimdall
Copy link

cb-heimdall commented Dec 30, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Dec 30, 2025

@phdargen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@CarsonRoscoe CarsonRoscoe merged commit e87c0e7 into coinbase:main Jan 5, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants