use msbuild -version, not %VisualStudioVersion% #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to make Colcon more friendly with github actions, since the Github action only sets the PATH to the current build tools.
|
FYI, the stuff in |
rotu
added a commit
to rotu/action-ros-ci
that referenced
this pull request
Aug 28, 2020
rotu
added a commit
to rotu/action-ros-ci
that referenced
this pull request
Aug 28, 2020
dirk-thomas
reviewed
Aug 31, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dirk-thomas
reviewed
Aug 31, 2020
dirk-thomas
reviewed
Aug 31, 2020
rotu
added a commit
to rotu/action-ros-ci
that referenced
this pull request
Sep 11, 2020
- If the user has activated MSBuild (e.g. with the action `microsoft/setup-msbuild`), respect it instead of sourcing msbuild. - (esp. if using PowerShell) don't wrap commands in an additional layer of cmd - convert build-and-test to a github composite action - add many more (too many?) variations to the ros2 matrix Signed-off-by: Dan Rose <dan@digilabs.io> Check for msbuild instead of %VisualStudioVersion% Depends on colcon/colcon-cmake#92
dirk-thomas
reviewed
Sep 22, 2020
|
|
||
| :rtype: str | ||
| """ | ||
| completed_process = subprocess.run( |
There was a problem hiding this comment.
Please invoke check_output instead of run since that is what it is used for here.
| @functools.lru_cache(maxsize=1) | ||
| def get_msbuild_version(): | ||
| """ | ||
| Get the version of msbuild or throw an exception. |
There was a problem hiding this comment.
The docblock should contain more information what kind of exceptions can be raised. This should use the :raises ExceptionType: ... style.
| '14.0': 'Visual Studio 14 2015', | ||
| } | ||
| if vsv not in supported_vsv: | ||
| 'msbuild is not found, ' |
There was a problem hiding this comment.
Nitpick: instead if "is" it should be "was".
|
@rotu Friendly ping. |
1 similar comment
|
@rotu Friendly ping. |
|
Closing due to no response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Windows, instead of using
%VisualStudioVersion%, usemsbuild -versionThis is intended to make
colcon-cmakemore friendly to Github actions. Themicrosoft/setup-msbuildaction does not populate%VisualStudioVersion%, socolcon-cmakecrashes on that platform.Here is a workflow demonstrating the issue and the proposed fix:
https://github.com/rotu/ros2-ci/actions/runs/233271645/workflow