Setup-MSBuild Compatibility #321
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotu
force-pushed
the
patch-4
branch
4 times, most recently
from
a3cb399
to
69b22dd
Compare
rotu
changed the title
- If the user has activated MSBuild (e.g. with the action `microsoft/setup-msbuild`), respect it instead of sourcing msbuild. - (esp. if using PowerShell) don't wrap commands in an additional layer of cmd - convert build-and-test to a github composite action - add many more (too many?) variations to the ros2 matrix Signed-off-by: Dan Rose <dan@digilabs.io> Check for msbuild instead of %VisualStudioVersion% Depends on colcon/colcon-cmake#92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to initialize VS build tools in GitHub CI with https://github.com/microsoft/setup-msbuild.
Depends on colcon/colcon-cmake#92