Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correction travis #866

Merged
merged 1 commit into from
Sep 25, 2019
Merged

correction travis #866

merged 1 commit into from
Sep 25, 2019

Conversation

Mubra
Copy link
Member

@Mubra Mubra commented Sep 24, 2019

No description provided.

idgserpro
idgserpro approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@idgserpro idgserpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good for me. Thank you for your pull request.

@idgserpro idgserpro requested a review from hvelarde September 25, 2019 00:17
@idgserpro
Copy link
Member

@Mubra a tip. When creating a branch, name it to reflect what you are doing. Here for example a good name would be fix_travis.

@hvelarde can you invite @Mubra to Collective Organization? I tried but couldn't. Then he can create branches in the collective/collective.cover itself.

@idgserpro
Copy link
Member

@scmos FYI

@Mubra
Copy link
Member Author

Mubra commented Sep 25, 2019

@idgserpro Good morning, the change in travis, when will it be reflected? Then, because I want to upload the correction of #861 and I know that this change has to be included for the travis tests to work

@hvelarde hvelarde merged commit b790f1f into collective:master Sep 25, 2019
@idgserpro idgserpro mentioned this pull request Oct 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idgserpro idgserpro idgserpro approved these changes

@hvelarde hvelarde Awaiting requested review from hvelarde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mubra @idgserpro @hvelarde