Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed travis-5.2.x.cfg and updated docs #52

Merged
merged 3 commits into from
Oct 9, 2019

Conversation

mauritsvanrees
Copy link
Member

The documentation no longer advertises to use the buildout-cache.cfg anymore, which is what happens with the travis configs.
Plus other small fixes in the documentation.
This fixes issue #51.

Additionally we could try to warn current users of the travis-*.cfg files by making sure an extra deprecated part gets loaded. But we can try that afterwards.

First let's have better documentation.

…he.cfg anymore.

Plus other small fixes in the documentation.
Fixes #51
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved

The versions are optional, but they can help in avoiding restarts when buildout tries to upgrade itself to a version pinned in Plone.
It is fine to start without them, but when you run into problems in `Travis CI`_, consider adding them.
In this way, all Plone versions use the same buildout and setuptools versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can, but they don't have to. Latest buildout and setuptools work fine for all current versions of Plone. With the same version, we avoid the need for extra files.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated
cache:
pip: true
directories:
- eggs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indentation here would be good.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated
install:
- bin/buildout -N -t 3
script:
- bin/$TARGET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the indentation here would be good.

README.rst Outdated Show resolved Hide resolved
@idgserpro
Copy link
Member

@mauritsvanrees since travis-5.x.cfg is broken too, I think it might be empty, only with a deprecated warning.

README.rst Outdated Show resolved Hide resolved
@mauritsvanrees
Copy link
Member Author

since travis-5.x.cfg is broken too, I think it might be empty, only with a deprecated warning.

Ah, right, you mentioned that earlier. It uses plone-series = 5.1 and extends the 5-latest versions, and that is not a working combination, and cannot easily be fixed.
I will add a comment in the travis file.

It was broken, because it makes a bad combination of plone-series and the UnifiedInstaller location.
@mauritsvanrees
Copy link
Member Author

Approved. I merge the PR myself.

@mauritsvanrees mauritsvanrees merged commit 1624c46 into master Oct 9, 2019
@mauritsvanrees mauritsvanrees deleted the maurits/no-travis-cfg-in-docs branch October 9, 2019 14:27
gotcha added a commit to gotcha/buildout.plonetest that referenced this pull request Nov 20, 2019
@gotcha gotcha mentioned this pull request Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants