-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed travis-5.2.x.cfg and updated docs #52
Conversation
…he.cfg anymore. Plus other small fixes in the documentation. Fixes #51
|
||
The versions are optional, but they can help in avoiding restarts when buildout tries to upgrade itself to a version pinned in Plone. | ||
It is fine to start without them, but when you run into problems in `Travis CI`_, consider adding them. | ||
In this way, all Plone versions use the same buildout and setuptools versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't each version of Plone have its own version of zc.buildout/setuptools?
see:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can, but they don't have to. Latest buildout and setuptools work fine for all current versions of Plone. With the same version, we avoid the need for extra files.
README.rst
Outdated
cache: | ||
pip: true | ||
directories: | ||
- eggs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the indentation here would be good.
README.rst
Outdated
install: | ||
- bin/buildout -N -t 3 | ||
script: | ||
- bin/$TARGET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the indentation here would be good.
@mauritsvanrees since |
Ah, right, you mentioned that earlier. It uses |
It was broken, because it makes a bad combination of plone-series and the UnifiedInstaller location.
Approved. I merge the PR myself. |
The documentation no longer advertises to use the
buildout-cache.cfg
anymore, which is what happens with the travis configs.Plus other small fixes in the documentation.
This fixes issue #51.
Additionally we could try to warn current users of the
travis-*.cfg
files by making sure an extra deprecated part gets loaded. But we can try that afterwards.First let's have better documentation.