Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let travis-5.x.cfg use plone-series 5.2. #50

Closed
wants to merge 1 commit into from

Conversation

mauritsvanrees
Copy link
Member

Otherwise is creates a wrong download:
https://launchpad.net/plone/5.1/5.2.0/...
See #10 (comment)

@@ -1,7 +1,7 @@
[buildout]
extends = test-5.x.cfg buildout-cache.cfg
parts = download install test
plone-series = 5.1
plone-series = 5.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have problems:

Installing download.
Downloading https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz
While:
  Installing download.
Error: Error downloading extends for URL https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz: HTTP Error 404: Not Found

The UnifiedInstaller url of Plone 5.2 in launchpad is:

https://launchpad.net/plone/5.2/5.2/+download/Plone-5.2.0-UnifiedInstaller.tgz

But download part tries to download:

https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz

This is because download part uses ${versions:Plone} to set the version, but the Plone version at:

https://dist.plone.org/release/5-latest/versions.cfg

is 5.2.0 and not 5.2.

This also occurs in travis-5.2.x.cfg.

This probably not will occur when Plone 5.2.1 is released.

I still think this file should be empty, only with a deprecated warning.

@mauritsvanrees
Copy link
Member Author

Ah, I did not yet realise that plone-series was not the only problem.
I guess that we could duplicate the Launchpad 5.2 release into 5.2.0 to solve the second problem.

But since it hasn't worked yet for 5.2, we could indeed decide to stop supporting this way of using buildout.plonetest. For 5.2 release candidates it could have actually worked, but it does not look like many were using it. Searching for travis-5.2.cfg in the collective gives 65 results, but that is because the match is inexact: it also reports anything with travis-5 and cfg. Most of the matches are the expected 5.x, and very few are 5.0 or 5.1, and no 5.2.

So the plan then seems:

  • Remove travis-5.2.cfg. Or make it empty, but I suspect that this could make it hard for people to see what is wrong: buildout silently continues.
  • Let travis-5.x.cfg extend test-5.1.cfg to keep existing add-ons functioning.

I think that is what you have been saying all along. It took me a while to get round to your way of thinking. :-)

@idgserpro
Copy link
Member

idgserpro commented Aug 20, 2019

Almost nobody must be using travis-5.2.cfg, so I am in favor of removing it.

For others we can add a part:

[deprecated]
recipe = collective.recipe.cmd
on_install = true
cmds =
    echo DEPRECATED: The use of travis-x.x.cfg is deprecated. Use Travis cache, according to documentation ...

@mauritsvanrees
Copy link
Member Author

Such an extra part seems like a good idea!
Meanwhile, I will close the current PR.

@mauritsvanrees mauritsvanrees deleted the maurits/fix-plone-series-5x-issue-10 branch August 20, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants