-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let travis-5.x.cfg use plone-series 5.2. #50
Conversation
Otherwise is creates a wrong download: https://launchpad.net/plone/5.1/5.2.0/... See #10 (comment)
@@ -1,7 +1,7 @@ | |||
[buildout] | |||
extends = test-5.x.cfg buildout-cache.cfg | |||
parts = download install test | |||
plone-series = 5.1 | |||
plone-series = 5.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have problems:
Installing download.
Downloading https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz
While:
Installing download.
Error: Error downloading extends for URL https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz: HTTP Error 404: Not Found
The UnifiedInstaller url of Plone 5.2 in launchpad is:
https://launchpad.net/plone/5.2/5.2/+download/Plone-5.2.0-UnifiedInstaller.tgz
But download part tries to download:
https://launchpad.net/plone/5.2/5.2.0/+download/Plone-5.2.0-UnifiedInstaller.tgz
This is because download part uses ${versions:Plone} to set the version, but the Plone version at:
https://dist.plone.org/release/5-latest/versions.cfg
is 5.2.0
and not 5.2
.
This also occurs in travis-5.2.x.cfg
.
This probably not will occur when Plone 5.2.1 is released.
I still think this file should be empty, only with a deprecated warning.
Ah, I did not yet realise that But since it hasn't worked yet for 5.2, we could indeed decide to stop supporting this way of using So the plan then seems:
I think that is what you have been saying all along. It took me a while to get round to your way of thinking. :-) |
Almost nobody must be using For others we can add a part: [deprecated]
recipe = collective.recipe.cmd
on_install = true
cmds =
echo DEPRECATED: The use of travis-x.x.cfg is deprecated. Use Travis cache, according to documentation ... |
Such an extra part seems like a good idea! |
Otherwise is creates a wrong download:
https://launchpad.net/plone/5.1/5.2.0/...
See #10 (comment)