Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions. Drop 3.4, 3.5, PyPy2 #340

Merged
merged 8 commits into from
Jul 11, 2022
Merged

Conversation

mauritsvanrees
Copy link
Member

No description provided.

@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@mauritsvanrees mauritsvanrees marked this pull request as ready for review November 22, 2021 21:24
These Python versions are out of support.
3.4 is no longer available on Ubuntu 20 on GitHub Actions.
Not available on GHA for latest Ubuntu 20.
@mauritsvanrees mauritsvanrees changed the title Use GitHub Actions. Use GitHub Actions. Drop 3.4, 3.5, PyPy2 Nov 22, 2021
@mauritsvanrees
Copy link
Member Author

This needs help. Locally on my Mac, tox goes fine. But on GHA I get errors:

21
____ ERROR collecting build/lib/icalendar/tests/hypothesis/test_fuzzing.py _____
22
ImportError while importing test module '/home/runner/work/icalendar/icalendar/build/lib/icalendar/tests/hypothesis/test_fuzzing.py'.
23
Hint: make sure your test modules/packages have valid Python names.
24
Traceback:
25
/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/importlib/__init__.py:127: in import_module
26
    return _bootstrap._gcd_import(name[level:], package, level)
27
build/lib/icalendar/tests/hypothesis/test_fuzzing.py:3: in <module>
28
    from hypothesis import given, settings
29
E   ModuleNotFoundError: No module named 'hypothesis'
30

From looking at tox.ini, this file is only meant to be run on 2.7 and 3.6, where hypothesis is installed. I don't know why we would want to skip this test on other Python versions.
Locally, the test is probably not even found, so there are no complaints.

The rest of the errors is like this:

____________ ERROR collecting src/icalendar/tests/test_encoding.py _____________
31
import file mismatch:
32
imported module 'icalendar.tests.test_encoding' has this __file__ attribute:
33
  /home/runner/work/icalendar/icalendar/build/lib/icalendar/tests/test_encoding.py
34
which is not the same as the test file we want to collect:
35
  /home/runner/work/icalendar/icalendar/src/icalendar/tests/test_encoding.py
36
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules

Otherwise you get crazy errors.
@mauritsvanrees
Copy link
Member Author

Yes! All green, except the Jenkins tests that we can ignore. I have now disabled the web hooks for those. That might help for new PRs. If these checks still end up in new PRs, please ping me, then I need to have a deeper look.

@mauritsvanrees mauritsvanrees merged commit 08ab964 into master Jul 11, 2022
@mauritsvanrees mauritsvanrees deleted the github-actions branch July 11, 2022 11:30
@jacadzaca jacadzaca linked an issue Sep 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tox.ini extras declared in wrong way
2 participants