-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Setup process for development #358
Conversation
@niccokunzmann thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
So, I see this: Plone Jenkins CI - pull-request-6.0-3.7:
Much more in Plone Jenkins CI - pull-request-5.2-3.6. Is there some explanation for this? Why are all these tests running? Where can I read more about this? |
We should probably disable Jenkins tests for this package. We would need a replacement though. Last year I tried but failed to add GitHub actions. I have created a post on the Plone community forum about the future of this package, and needing a maintainer for it. |
We have set up GitHub actions for running tests for khal (which heavily relies on icalendar), I can give it a go. |
Actually, let me open op discussions in this repository: #360 |
Thanks, that would be very welcome. I know enough about tox and GitHub actions, but haven't spent enough time improving it for this repo. There may be some very basic things amiss in the tox setup. If you open a PR for that, please ping or assign me and I can have a look. I was not even watching this repo with notifications until just now. And since you are the number three contributor to this package, you would be a prime candidate to be a new maintainer, if you want. :-) |
this also removes the unsupported/untested Python versions
Pull Request Test Coverage Report for Build 2814204215Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
This pull request aims at clarifying how to setup icalendar for development.