update travis config to latest rubies #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also skip testing rails-4.x with ruby-head. We're not testing them with ruby-2.4 and they fail anyway. |
tbrisker
reviewed
Dec 3, 2017
| - 2.4.1 | ||
| - 2.2.8 | ||
| - 2.3.5 | ||
| - 2.4.2 |
There was a problem hiding this comment.
maybe just drop the z part so we're always testing with the latest version of each line?
There was a problem hiding this comment.
I'm ok with that but went this way to leave the project's existing style alone. Some projects actively don't like to do it that way. Occasionally it seems that Travis gets the logic behind that wrong - i.e., for a while this summer 2.2 was getting you 2.2.1 not 2.2.8 like you'd expect.
There was a problem hiding this comment.
@danielmorrison any preference?
tbrisker
force-pushed
the
update_rubies
branch
from
4a13487 to
180d7fe
Compare
tbrisker
approved these changes
Dec 31, 2017
|
@lostapathy Thanks, I pushed a rebase to your branch to fix the merge conflicts, will merge once travis is 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating travis config to cover latest ruby versions