Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis config to latest rubies #386

Merged
merged 2 commits into from
Dec 31, 2017
Merged

update travis config to latest rubies #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
190104e
update to latest rubies
lostapathy Nov 13, 2017
180d7fe
don't test rails-4.x with ruby-head
lostapathy Nov 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ language: ruby
cache: bundler
rvm:
- 2.1
- 2.2.4
- 2.3.1
- 2.4.1
- 2.2.8
- 2.3.5
- 2.4.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just drop the z part so we're always testing with the latest version of each line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that but went this way to leave the project's existing style alone. Some projects actively don't like to do it that way. Occasionally it seems that Travis gets the logic behind that wrong - i.e., for a while this summer 2.2 was getting you 2.2.1 not 2.2.8 like you'd expect.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmorrison any preference?

- ruby-head
env:
- DB=SQLITE
Expand All @@ -29,9 +29,13 @@ matrix:
gemfile: gemfiles/rails51.gemfile
- rvm: 2.1
gemfile: gemfiles/rails52.gemfile
- rvm: 2.4.1
- rvm: 2.4.2
gemfile: gemfiles/rails40.gemfile
- rvm: 2.4.1
- rvm: 2.4.2
gemfile: gemfiles/rails41.gemfile
- rvm: ruby-head
gemfile: gemfiles/rails40.gemfile
- rvm: ruby-head
gemfile: gemfiles/rails41.gemfile
fast_finish: true
branches:
Expand Down
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ For Rails 3, use gem version 3.0 or see the [3.0-stable branch](https://github.c

Audited supports and is [tested against](http://travis-ci.org/collectiveidea/audited) the following Ruby versions:

* 2.1.5
* 2.2.4
* 2.3.1
* 2.4.1
* 2.1.10
* 2.2.8
* 2.3.5
* 2.4.2

Audited may work just fine with a Ruby version not listed above, but we can't guarantee that it will. If you'd like to maintain a Ruby that isn't listed, please let us know with a [pull request](https://github.com/collectiveidea/audited/pulls).

Expand Down