Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all_audits method to auditable models #428

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Add all_audits method to auditable models #428

merged 2 commits into from
Apr 4, 2018

Conversation

fatkodima
Copy link
Contributor

Closes #114
Closes #117

tbrisker
tbrisker reviewed Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Just one comment on the method name, all_audits might not be clear that it includes associated ones, perhaps something like own_and_associated_audits or any shorter name if you can think of one?

@fatkodima
Copy link
Contributor Author

Updated with new name. own_and_associated_audits looks pretty clear 👍

tbrisker
tbrisker approved these changes Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@tbrisker tbrisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fatkodima !

@tbrisker tbrisker merged commit fd95166 into collectiveidea:master Apr 4, 2018
@Kani999
Copy link

Kani999 commented Oct 25, 2018

@tbrisker When it will be released?

@tbrisker
Copy link
Collaborator

@Kani999 it has been released in 4.8.0 in August.

@Kani999
Copy link

Kani999 commented Oct 26, 2018

@tbrisker - I've been confused because of the changelog.

https://github.com/collectiveidea/audited/blob/master/CHANGELOG.md#unreleased

@tbrisker
Copy link
Collaborator

@Kani999 ah, you're right, looks like the changelog in the master branch didn't get updated with the 4.8.0 changes. PRs welcome 😉

@eric-hemasystems eric-hemasystems mentioned this pull request May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrisker tbrisker tbrisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatkodima @Kani999 @tbrisker