own_and_associated_audits for STI #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 15, 2020 11:01
When attempting to run the test suite I received the following error:
Failure/Error: RailsApp::Application.initialize!
Sprockets::Railtie::ManifestNeededError:
Expected to find a manifest file in `app/assets/config/manifest.js`
But did not, please create this file and use it to link any assets that need
to be rendered by your app:
Example:
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css
and restart your server
# ./spec/rails_app/config/environment.rb:5:in `<top (required)>'
# ./spec/spec_helper.rb:9:in `<top (required)>'
# ./spec/audited/sweeper_spec.rb:1:in `<top (required)>'
This is reflected on CI with the new versions of Rails failing on the
same error:
https://travis-ci.org/github/collectiveidea/audited/jobs/686147718
Rather than create a dummy file it seemed best to just remove the
Sprockets dependency. At first I was going to include all the other
Rails libraries listed at:
https://github.com/rails/rails/blob/master/railties/lib/rails/all.rb
I decided to cut it down further because some of these other support
libraries that we are not using may in the future cause similar issues.
Since they are not relevant to the `audited` gem it seemed good to head
off that issue.
I confirmed only the ActiveRecord support needs to be included as
long as I commented out any config related to the other components
(ActionMailer config in `test.rb`).
With ActionController now gone it seems we don't need the dummy
ApplicationController file anymore.
Finally while cleaning things up it seems we don't need development
and production environments since the test suite always runs in the
test environment.
This may all be cutting too deep. Maybe I can't trim as much with
and older version of Rails that is still supported by the `audited` gem.
If CI informs me of that I can roll back some of these cuts.
|
Looking through the CI results I see:
|
|
Any feedback on this. Just updated to the latest on master. Would love to get this merged so I don't have to maintain my own branch. 😉 |
|
Looking at CI results I don't see anything related to this PR. Seems CI related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
own_and_associated_auditswas introduced in PR #428 it did not take STI models into account. This PR fixes the problem.I got an error when trying to run the test suite locally. This error also affects many of the CI builds. 72da59f fixes that issue and although unrelated to my goal is actually most of the changes for this PR. See the commit message for more info.
f5d9899 adds some tests that duplicate the problem and 489224e is the very small change to fix the issue.