-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Class Python Support (4000USD Bounty) #3928
Comments
@lihaoyi Ready for this but need your Guidance (in between) I think we should do this in parts... |
@himanshumahajan138 yes, will need to think about the best way to approach this. It would be a pretty large scale effort and will definitely need to be broken down into parts |
Aaah! Great approach for subparts Working on this as it will require huge code base so will start from small to big Let's do this ✨ |
@lihaoyi I want(have) to create a Proper So, I request to avoid Clashes if anyone trying to do this please once comment... |
@lihaoyi Perhaps It would be useful to clarify how |
@mpkocher I don't actually know yet, we'll probably need to figure that out as we flesh out the implementation |
For anyone reading, I merged #3970 which sets up the basic scaffolding:
From there you should be able to iterate on the examples necessary for this ticket's bullet points to flesh out the necessary functionality |
@lihaoyi that's great you just gave the foundation brick for the building ✨ |
Also the example Python module walkthrough is mandatory reading for anyone who wants to start on this https://mill-build.org/mill/extending/example-python-support.html |
@lihaoyi i will work on this expanding the previous code just after completing the kotlin springboot |
There's this new Python tool https://rye.astral.sh which may be a source of inspiration for Mill support for Python. What is innovative about Rye, compared to previous Python tools is that it's aiming to be a one-stop tool for anything related to working with a Python project:
If Mill covered well a broad spectrum of workflows people working with Python need to do, coupled with Mill's goodies, like implicit parallelism and aggressive caching, it could be a tempting proposal for at least part of the Python community. Good luck with this! 🤞 |
@lihaoyi actually i was working and stuck at some testing part as per the official python docs i have seen that python use Now the question is what way we have to follow ? by the way i have used unittest for now when i will raise PR we will Groom it there for sure... Thanks... |
Features of
Yeah, |
Yes! but the way @lihaoyi is doing (check the other examples in javalib and others) i am concerned about that coz i didn't got any docs and unable to get a spike of learning 😅 I think @lihaoyi have to provide some Guide and through some light on it |
Cross-posting a comment from #3992 here. I'll work on the missing fundamentals (test support, repl etc), then @himanshumahajan138 will take care of the |
I'll work on dependencies next, now that #3992 is almost done |
This is in view of #3928, specifically some essential things required for the first task, `example/pythonlib/basic/`. You can look at commits individually if you like. The gist of this PR is to improve the scaffolding we currently have to unblock the previously mentioned tasks. It can be summarized by the following points (roughly each corresponding to one commit): - [x] make `run` task the default, following the same convention used in `ScalaModule` and `JavaModule` - [x] add a command to run an interactive REPL. This is named `console`, again following the conventions of scalalib - [x] rework the way source files are handled: - support multiple source directories, again following similar conventions of scalalib - instead of aggreting python scripts in one syntetic directory, keep them where they are and instead manipulate PYTHONPATH or pass in parameters to various directories where appropriate - [x] define a module for unit tests, similar to the TestModule of scalalib
From the maintainer Li Haoyi: I'm putting a 4000USD bounty on this issue, payable by bank transfer on merged PRs implementing this. Standard bounty terms apply
Python is common in industry, and lacks good build tools. Mill could a be a good tool to help manage large multi-module Python projects (see What Makes Mill Unique?) providing automatic caching and parallelism for the various workflows (dependency resolution, typechecking, testing, packaging, publishing) that are core to the local development experience to help keep them fast and responsive.
The goal of this ticket is to generate a set of Python build examples that match the Java/Scala/Kotlin equivalents. We already have an example PythonModule for demo purposes, but we would need to flesh it out using the equivalent Python tools and libraries.
For the purposes of this ticket, each examples should match as closely as possible the Java/Scala/Kotlin equivalents, to provide a useful minimal-but-still-educational code example, along with associated english documentation and explanations. You should read through the relevant sections of the Building Java with Mill documentation before proceeding, even if you don't know Java, just to get a feel for what the documentation and examples for each section should cover.
example/pythonlib/basic/
(500USD)1-simple/
: A minimal Python module demonstrating typechecking/running/testing/pex2-custom-build-logic/
: A Python module with custom build logic3-multi-modules/
: Multiple inter-related Python modulesexample/pythonlib/dependencies/
(500USD)1-pip-deps/
2-unmanaged-wheels/
3-downloading-unmanaged-wheels/
4-repository-config/
: examples of how to use alternate PyPI mirrors or repositoriesexample/pythonlib/linting/
(1000USD)1-black/
: equivalent to1-scalafmt
but using Black2-code-coverage/
: not sure what the popular Python code coverage lib is, but they should have something3-ruff/
: using Ruff to lint the Python codeexample/pythonlib/module/
(500USD)1-common-config/
2-custom-tasks/
3-override-tasks/
4-compilation-execution-flags/
5-resources/
6-pex-config/
example/pythonlib/testing/
(500USD)1-test-suite/
: we should have examples of Python being used with at least two different testing frameworks:pytest
andunittest
2-test-deps/
3-integration-suite/
example/pythonlib/publishing/1-publish-module/
,example/pythonlib/basic/4-realistic/
(500USD)publishing/1-publish-module
should demonstrate how to publish a Python package to PyPIbasic/4-realistic
is only doable after all the previous bullets are done, so I'm grouping its bounty together withpublishing/
example/pythonlib/web/
(500USD)1-hello-flask/
: hello world website using Flask framework2-todo-flask/
: TodoMVC webapp using Flask frameworkexample/pythonlib/web/
(500USD)3-hello-django/
:hello world website using Django framework4-todo-django/
: TodoMVC webapp using Django frameworkThe text was updated successfully, but these errors were encountered: