Fixed: #3928 [Module Examples] Add First Class Python Support

[himanshumahajan138]

Pull Request

Added First Class Python Support [Module Examples]
Part of: #3928

Description

Module Examples for Python 1-common-config, 2-custom-tasks, 3-override-tasks, 4-compilation-execution-flags, 5-resources, 6-pex-config Examples

Related Issues

• Link to related issue First Class Python Support (4000USD Bounty) #3928.

Checklist

• 1-common-config
• 2-custom-tasks
• 3-override-tasks
• 4-compilation-execution-flags
• 5-resources
• 6-pex-config
• Updated Documentation

Status

Added & Require Review!!!

[himanshumahajan138]

(@lihaoyi and @jodersky) Sir Let's Review this PR as Backbone support (Documentation will be updated after finalizing the Code)

Also @lihaoyi guide me for what kind of configs we needs to add for pex config example are we targeting specific bundle args or something else ???

[himanshumahajan138]

@lihaoyi Sir please guide me,

Why this error is coming where i have used show command in cli test case???

[3297] /home/runner/work/mill/mill/out/example/pythonlib/module/2-custom-tasks/local/testCached.dest/sandbox/run-2> ./mill --disable-ticker show lineCount
[3297] --- Expected output ----------
[3297] 22
[3297] ------------------------------
[3298] /home/runner/work/mill/mill/out/example/pythonlib/module/1-common-config/local/testCached.dest/sandbox/run-2> ./mill --disable-ticker show bundle
[3298] --- Expected output ----------
[3298] ".../out/bundle.dest/bundle.pex"
[3298] ------------------------------

This happens for both of the test cases
 
[3297]   utest.AssertionError: else assert(evalResult.isSuccess)
[3297]   evalResult: mill.testkit.IntegrationTester.EvalResult = EvalResult(false,mill-server/ exitCode file not found
[3297]   ,)...............more below

These Test Cases are running perfect in local but i am not getting why this error is happening in CI please help...

I got Biggest Annoying thing....

when i added the code under foo folder in the latest commit then it worked for show command what is happening here sir please explain me....

[jodersky]

In general this looks like it's on the right track.

If you can add explanations to the examples I can give it another look

[himanshumahajan138]

@lihaoyi @jodersky
Ready for Review!

[himanshumahajan138]

@lihaoyi @jodersky anyone Up There ???

[lihaoyi]

@jodersky I'll leave this review to you, feel free to merge this when you think it's in good state and I'll pay out the bounty

[jodersky]

This is starting to look good for a merge. I left a couple of comments, but once those are cleared we can merge it.

[himanshumahajan138]

@jodersky Let's Finalize this if satisfied

[jodersky]

Let's merge this

[jodersky]

Thanks!

[himanshumahajan138]

Great, @jodersky and @lihaoyi Thanks for your Guidance and support...

[jodersky]

@himanshumahajan138, one minor comment: for the following PRs, could you please not say "fixed #3928" in the title, but instead "part of #3928". If you include the words "fixed" or "closes", then github will automatically close the linked issue, which we don't want in this case

[himanshumahajan138]

@himanshumahajan138, one minor comment: for the following PRs, could you please not say "fixed #3928" in the title, but instead "part of #3928". If you include the words "fixed" or "closes", then github will automatically close the linked issue, which we don't want in this case

OK Sir 😊 i will take care for future PR's...

[lihaoyi]

Thanks @himanshumahajan138, I'll transfer this portion of the bounty using your existing bank details