Fix: Stop minifying in fastLinkJS
#4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternative to this is to make `scalaJSMinify` an anonymous task, which is not binary compatible (we can have this change in a future major version). Mill doesn't have `fastLinkJS` and `fullLinkJS` scopes as Sbt which makes it difficult to have specific settings for `fullLinkJS` only. This PR makes Mill behave like 99% of people want, which is what Sbt does by default. The downside is that it's now impossible to test what happens with minify on `fastLinkJS``, but the workaround is to directly test on `fullLinkJS` in that scenario.
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alternative to this is to make
scalaJSMinifyan anonymous task, which is not binary compatible (we can have this change in a future major version).Mill doesn't have
fastLinkJSandfullLinkJSscopes as Sbt which makes it difficult to have specific settings forfullLinkJSonly. This PR makes Mill behave like 99% of people want, which is what Sbt does by default. The downside is that it's now impossible to test what happens with minify onfastLinkJS, but the workaround is to directly test onfullLinkJSin that scenario.Pull Request: #4051