Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Stop minifying in fastLinkJS #4051

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Fix: Stop minifying in fastLinkJS #4051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scalajslib/src/mill/scalajslib/ScalaJSModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ trait ScalaJSModule extends scalalib.ScalaModule { outer =>
def scalaJSOutputPatterns: T[OutputPatterns] = Task { OutputPatterns.Defaults }

/**
* Apply Scala.js-specific minification of the produced .js files.
* Apply Scala.js-specific minification of the produced .js files in fullLinkJS.
*
* When enabled, the linker more aggressively reduces the size of the
* generated code, at the cost of readability and debuggability. It does
Expand Down
3 changes: 2 additions & 1 deletion scalajslib/worker/1/src/mill/scalajslib/worker/ScalaJSWorkerImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,8 @@ class ScalaJSWorkerImpl extends ScalaJSWorkerApi {
else withModuleSplitStyle

val withMinify =
if (minorIsGreaterThanOrEqual(16)) withOutputPatterns.withMinify(input.minify)
if (minorIsGreaterThanOrEqual(16))
withOutputPatterns.withMinify(input.minify && input.isFullLinkJS)
else withOutputPatterns

val withWasm =
Expand Down
Loading