Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix SclReport behavior #304

Closed
samirromdhani opened this issue Aug 8, 2023 · 0 comments · Fixed by #305
Closed

Refactor and fix SclReport behavior #304

samirromdhani opened this issue Aug 8, 2023 · 0 comments · Fixed by #305
Labels
enhancement New feature or request

Comments

@samirromdhani
Copy link
Contributor

samirromdhani commented Aug 8, 2023 •
edited by massifben
Loading

User Story

As a developer

  • I want that methods which provide SclReport object to return a list of reported errors instead, because it will be more convenient for callers to chain methods calls, and because SclReport includes a SclRootAdapter whose current element is the SCL instance given in parameter. It is useless to return the SclRootAdapter because the caller already has the SCL instance.
  • I want to fix some methods that employ invalid signatures, an example for that: the object SclRootAdapter should be replaced by SCL object in parameters and/or return value.
@samirromdhani samirromdhani added the enhancement New feature or request label Aug 8, 2023
samirromdhani added a commit that referenced this issue Aug 8, 2023
@samirromdhani
feat: refactor and fix SclReport behavior #304
0511d0c 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
@samirromdhani samirromdhani linked a pull request Aug 8, 2023 that will close this issue
feat: refactor and fix SclReport behavior #304 #305
Merged
samirromdhani added a commit that referenced this issue Aug 9, 2023
@samirromdhani
feat: refactor and fix SclReport behavior #304
74be352 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani added a commit that referenced this issue Aug 9, 2023
@samirromdhani
feat: refactor and fix SclReport behavior #304
c78eeb0 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani added a commit that referenced this issue Aug 11, 2023
@samirromdhani
feat: refactor and fix SclReport behavior #304
809106b 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

refactor test code to use AssertJ and using Gherkin to define scenarios #306

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani added a commit that referenced this issue Aug 11, 2023
@samirromdhani
feat: refactor and fix SclReport behavior #304
0098f0d 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani added a commit that referenced this issue Aug 11, 2023
@samirromdhani
review feedback
1f0ae37 
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

revert changes related to other issue (Refactor tests structure in compas-sct)

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>

feat: refactor and fix SclReport behavior #304

Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani added a commit that referenced this issue Aug 14, 2023
@samirromdhani
Merge pull request #305 from com-pas/feat/304-refactor-and-fix-sclrep…
8b8c2ce 
…ort-behavior

feat: refactor and fix SclReport behavior #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor and fix SclReport behavior #304 com-pas/compas-sct
1 participant
@samirromdhani