feat: refactor and fix SclReport behavior #304 #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirromdhani
force-pushed
the
feat/304-refactor-and-fix-sclreport-behavior
branch
from
0511d0c to
74be352
Compare
samirromdhani
force-pushed
the
feat/304-refactor-and-fix-sclreport-behavior
branch
from
74be352 to
c78eeb0
Compare
massifben
reviewed
Aug 9, 2023
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/ExtRefService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
samirromdhani
force-pushed
the
feat/304-refactor-and-fix-sclreport-behavior
branch
5 times, most recently
from
10a05da to
3e5f628
Compare
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> refactor test code to use AssertJ and using Gherkin to define scenarios #306 Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
force-pushed
the
feat/304-refactor-and-fix-sclreport-behavior
branch
4 times, most recently
from
6433df6 to
a02d8b0
Compare
massifben
reviewed
Aug 14, 2023
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/dto/ConnectedApDTO.java
Outdated
Show resolved
Hide resolved
sct-commons/src/main/java/org/lfenergy/compas/sct/commons/scl/SclService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> revert changes related to other issue (Refactor tests structure in compas-sct) Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
samirromdhani
force-pushed
the
feat/304-refactor-and-fix-sclreport-behavior
branch
from
a02d8b0 to
e071955
Compare
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com> revert changes related to other issue (Refactor tests structure in compas-sct) Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
Signed-off-by: Samir Romdhani <samir.romdhani@rte-france.com>
massifben
approved these changes
Aug 14, 2023
feat: rename SclReportItem#fatal to SclReportItem#error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.