-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPIK-432] Project Metrics MVP #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoberko2
force-pushed
the
ido/opik-432-project-metrics-mvp
branch
from
November 21, 2024 07:27
7a19eef
to
97124be
Compare
thiagohora
reviewed
Nov 21, 2024
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
thiagohora
reviewed
Nov 21, 2024
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
thiagohora
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job in general, just some concerns about the API
apps/opik-backend/src/main/java/com/comet/opik/api/AggregationType.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/metrics/MetricType.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/metrics/ProjectMetricRequest.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/metrics/ProjectMetricResponse.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/metrics/ProjectMetricResponse.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/api/metrics/ProjectMetricResponse.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsService.java
Outdated
Show resolved
Hide resolved
idoberko2
force-pushed
the
ido/opik-432-project-metrics-mvp
branch
from
November 21, 2024 13:14
f1cf3fd
to
f14d004
Compare
thiagohora
reviewed
Nov 21, 2024
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
thiagohora
approved these changes
Nov 21, 2024
aadereiko
pushed a commit
that referenced
this pull request
Nov 25, 2024
* OPIK-432 project metrics traces count failing test [WIP] * OPIK-432 project metrics traces count failing test * OPIK-432 project metrics traces count failing test * OPIK-432 project metrics traces count failing test * OPIK-432 project metrics traces count implementation [WIP] * OPIK-432 project metrics traces count implementation [WIP] * OPIK-432 project metrics traces count implementation [WIP] * OPIK-432 project metrics traces count implementation [WIP] * OPIK-432 project metrics traces count implementation [WIP] * OPIK-432 project metrics traces count failing test green * OPIK-432 validations failing test * OPIK-432 validations failing test green * OPIK-432 refactor * OPIK-432 cover auth * OPIK-432 code style * OPIK-432 code simplify * OPIK-432 use number * OPIK-432 fix comparison * OPIK-432 pr comments * OPIK-432 pr comments * OPIK-432 pr comments * OPIK-432 pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This adds the first project metrics API with a thin implementation:
Issues
OPIK-432
Testing
Added E2E that covers the above basic flows