Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-432] Project Metrics MVP #678

Merged
merged 22 commits into from
Nov 21, 2024
Merged

Conversation

idoberko2
Copy link
Contributor

@idoberko2 idoberko2 commented Nov 20, 2024

Details

This adds the first project metrics API with a thin implementation:

  • only "number of traces" is supported
  • only "hourly" interval is supported

Issues

OPIK-432

Testing

Added E2E that covers the above basic flows

@idoberko2 idoberko2 requested a review from a team as a code owner November 20, 2024 13:42
@idoberko2 idoberko2 self-assigned this Nov 20, 2024
@idoberko2 idoberko2 force-pushed the ido/opik-432-project-metrics-mvp branch from 7a19eef to 97124be Compare November 21, 2024 07:27
Copy link
Contributor

@thiagohora thiagohora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in general, just some concerns about the API

@idoberko2 idoberko2 force-pushed the ido/opik-432-project-metrics-mvp branch from f1cf3fd to f14d004 Compare November 21, 2024 13:14
@idoberko2 idoberko2 requested a review from thiagohora November 21, 2024 13:15
@idoberko2 idoberko2 merged commit ce8690a into main Nov 21, 2024
7 checks passed
@idoberko2 idoberko2 deleted the ido/opik-432-project-metrics-mvp branch November 21, 2024 20:16
aadereiko pushed a commit that referenced this pull request Nov 25, 2024
* OPIK-432 project metrics traces count failing test [WIP]

* OPIK-432 project metrics traces count failing test

* OPIK-432 project metrics traces count failing test

* OPIK-432 project metrics traces count failing test

* OPIK-432 project metrics traces count implementation [WIP]

* OPIK-432 project metrics traces count implementation [WIP]

* OPIK-432 project metrics traces count implementation [WIP]

* OPIK-432 project metrics traces count implementation [WIP]

* OPIK-432 project metrics traces count implementation [WIP]

* OPIK-432 project metrics traces count failing test green

* OPIK-432 validations failing test

* OPIK-432 validations failing test green

* OPIK-432 refactor

* OPIK-432 cover auth

* OPIK-432 code style

* OPIK-432 code simplify

* OPIK-432 use number

* OPIK-432 fix comparison

* OPIK-432 pr comments

* OPIK-432 pr comments

* OPIK-432 pr comments

* OPIK-432 pr comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants