[OPIK-395] Project Metrics - all but usage
#713
Merged
+421
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoberko2
force-pushed
the
ido/opik-395-project-metrics
branch
from
bd0a8a9 to
5ef40bc
Compare
thiagohora
reviewed
Nov 25, 2024
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsService.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/main/java/com/comet/opik/domain/ProjectMetricsDAO.java
Show resolved
Hide resolved
...k-backend/src/test/java/com/comet/opik/api/resources/v1/priv/ProjectMetricsResourceTest.java
Outdated
Show resolved
Hide resolved
idoberko2
force-pushed
the
ido/opik-395-project-metrics
branch
from
acae776 to
3ab0334
Compare
thiagohora
approved these changes
Nov 26, 2024
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR extends the MVP implemented in #678 to have the additional following functionality:
Support null range, i.e. "all time"- product requirements changed, these changes are revertednullback-fill instead of0This PR doesn't include the
usagemetric which will be introduced in a later PRIssues
Partially resolves OPIK-395
Testing
Added several E2E tests to cover the newly added scenarios.