Monero wallet refresh fix

[binarybaron]

This PR changes the following behaviour in the refresh functionality of the monero wallet

• Allows for multiple retries because in some cases users have experienced an issue where the wallet rpc returns no connection to daemon even though the daemon is available. I'm not 100% sure why this happens but retrying often fixes the issue
• Attempt to print the current sync height while the wallet is syncing. This only works to some degree because the monero-wallet-rpc stops responding (or takes a long time to respond) while it's refreshing
• The monero-wallet-rpc is started with the --no-initial-sync flag which ensures that as soon as it's started, it's ready to respond to requests
• The monero-wallet-rpc was upgraded to v0.18.3.1 because this PR Wallet refresh improvements monero-project/monero#8941 has improved some of the issues mentioned above

This PR is part of a larger effort to fix this issue #1432

[binarybaron]

This is still a draft. Please don't merge yet :)

[binarybaron]

@delta1 This is ready for review

[delta1]

Nice LGTM. Do you want to add a note to the changelog? At least for bumping the Monero version

[delta1]

seems like some tests are now running into the 6 hour CI time limit?

[binarybaron]

Nice LGTM. Do you want to add a note to the changelog? At least for bumping the Monero version

Good catch. I'll add one

[delta1]

@binarybaron a few of the ci jobs are not working with this change

[delta1]

@binarybaron a few of the ci jobs are not working with this change

@binarybaron this PR had broken one or more CI jobs.

[binarybaron]

Okay. I'll revert this PR if the CI jobs fail on master

[binarybaron]

@delta1 Okay it seems like some of the tests will time out. Looking at the logs it seems that the CI is stuck at refreshing the Monero wallet which seems related to this PR. I have no idea why.

When refreshing the CI calls this

xmr-btc-swap/swap/src/monero/wallet.rs

Line 265 in d8dacbd

pub async fn refresh(&self, max_attempts: usize) -> Result<Refreshed> {

function with max_attempts=1 .

This line

xmr-btc-swap/swap/src/monero/wallet.rs

Line 299 in d8dacbd

tracing::info!(name = %self.name, attempt=i, "Syncing Monero wallet");

is never reached. Nowhere in the logs is this log message to be found. The other tokio task which is responsible for logging the sync progress is called and prints periodic log messages.

Do you have any idea what the issue could be here? I'm clueless. Here is the entire function for reference:

xmr-btc-swap/swap/src/monero/wallet.rs

Lines 265 to 330 in d8dacbd

	pub async fn refresh(&self, max_attempts: usize) -> Result<Refreshed> {
	const GET_HEIGHT_INTERVAL: Duration = Duration::from_secs(5);
	const RETRY_INTERVAL: Duration = Duration::from_secs(2);
	let inner = self.inner.lock().await;
	// Cloning this is relatively cheap because reqwest::Client is a wrapper around an Arc
	let inner_clone = inner.clone();
	let wallet_name_clone = self.name.clone();
	let refresh_task = tokio::task::spawn(async move {
	loop {
	let height = inner_clone.get_height().await;
	match height {
	Err(error) => {
	tracing::debug!(name = %wallet_name_clone, %error, "Failed to get current Monero wallet sync height");
	}
	Ok(height) => {
	tracing::debug!(name = %wallet_name_clone, current_sync_height = height.height, "Syncing Monero wallet");
	}
	}
	tokio::time::sleep(GET_HEIGHT_INTERVAL).await;
	}
	});
	let refresh_result = tokio::select! {
	biased;
	_ = refresh_task => {
	unreachable!("Current sync height refresh task should never finish")
	}
	refresh_result = async {
	for i in 1..=max_attempts {
	tracing::info!(name = %self.name, attempt=i, "Syncing Monero wallet");
	let result = inner.refresh().await;
	match result {
	Ok(refreshed) => {
	tracing::info!(name = %self.name, "Monero wallet synced");
	return Ok(refreshed);
	}
	Err(error) => {
	let attempts_left = max_attempts - i;
	tracing::warn!(attempt=i, %attempts_left, name = %self.name, %error, "Failed to sync Monero wallet");
	if attempts_left == 0 {
	tracing::error!(name = %self.name, %error, "Failed to sync Monero wallet");
	return Err(error);
	}
	}
	}
	tokio::time::sleep(RETRY_INTERVAL).await;
	}
	unreachable!("Loop should always return before it breaks")
	} => {
	refresh_result
	}
	};
	Ok(refresh_result?)
	}
	}

[delta1]

revert in #1593 so we can recreate this while debugging

[delta1]

recreated this PR in #1594