Wallet refresh improvements #8941
Conversation
|
+1 , the |
| @@ -60,6 +60,7 @@ using namespace epee; | |||
| #define MONERO_DEFAULT_LOG_CATEGORY "wallet.rpc" | |||
|
|
|||
| #define DEFAULT_AUTO_REFRESH_PERIOD 20 // seconds | |||
| #define REFRESH_INFICATIVE_BLOCK_CHUNK_SIZE 256 // just to split refresh in separate calls to play nicer with other threads | |||
There was a problem hiding this comment.
Was inficative (not a word) meant to be indicative? Even indicative seems like an odd name choice, it's more like a default.
There was a problem hiding this comment.
Yes, it was. IIRC that value is only respected by monerod if the blocks aren't too big, so it's only indicative. Maybe "max" would have been better.
I won't bother changing it here since it's a copy of the master patch, which is already merged.
moneromooo-monero
force-pushed
the
is-0.18
branch
from
87ad380 to
356e687
Compare
|
I'm using the
Problem is that the rpc does not respond to |
This PR changes the following behaviour in the refresh functionality of the monero wallet - Allows for multiple retries because in some cases users have experienced an issue where the wallet rpc returns `no connection to daemon` even though the daemon is available. I'm not 100% sure why this happens but retrying often fixes the issue - Print the current sync height after each failed attempt at syncing to see how far we've come - The `monero-wallet-rpc` is started with the `--no-initial-sync` flag which ensures that as soon as it's started, it's ready to respond to requests - The `monero-wallet-rpc` was upgraded to `v0.18.3.1` because this PR monero-project/monero#8941 has improved some of the issues mentioned above This PR is part of a larger effort to fix this issue #1432
No description provided.