-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 24.04 #262
Ubuntu 24.04 #262
Conversation
* separate out qtwayland5 compilation * ubuntu 22.04 * temp build system image * remove bionic deps * temp packages update * update armhf packages * back to libstdc++6 * replaced remove dqt5-default meta package with actual depss * fix for build libqmi crashing with /usr/bin/env: 'python': No such file or directory * mapbox-gl-native gcc11 fix * openpilot_dependencies.sh change * ubuntu-base 24.04 daily current * apt install meson because PEP 668 * temp g++-11 for mapbox-gl-native * bump capnproto to 1.0.2 * temp build only agnos-compiler-mapbox-gl-native * Fixes for compiling mapbox-gl-native * Fixes for compiling ffmpeg * Build main system image again * pyopencl from git since no 2023.1.5 release since inducer/pyopencl#705 * Try to fix checkinstall - no success * apt capnproto & ffmpeg since can't figure out issue with checkinstall * Commented removed services disable * Ubuntu 24.04 currently has arm-none-eabi/12.2.1 but just use wildcard to go to first folder * pyclean is missing ?! * ubuntu-latest in tests workflow * Updated README * Reverted internal/package_ota.py changes * rebuilt kernel * poetry.lock update * Simplified build_system pipeline * headers for capnproto * Fix typo * Fix for checkinstall * Reverted apt capnproto & ffmpeg * Some cleaning in Dockerfile * 24.04 libwayland-client * libffi6:armhf deb file * Updated qtwayland * Revert "libffi6:armhf deb file" This reverts commit bb9cb5d. * libffi.so.6.0.4 * qt5-qmake qtbase5-dev qtbase5-dev-tools already in qt5-default * Removed qtwayland old files * checkinstall temp fix * QStandardPaths: wrong permissions on runtime directory /var/tmp/weston, 0770 instead of 0700 * temp permissions fix makes loading build spinner show * temp build optimization * 24.04 new libs * build kernel don't use tools on aarch64/arm64 * updated boot image and ko files * cleaning * switch to release 24.04 * wip - downgrade qt and libwayland * polkitd-pkla package to support polkit *.pkla * fixed issue with old qt needing libssl 1.1.1f * remove /.dockerenv file * more cleaning --------- Co-authored-by: Justin Newberry <justin@comma.ai> Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* bump version * /lib64 is now UsrMerged * latest pip poetry; poetry.lock update --------- Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Is this ready to be merged? If not, let's convert to draft. |
Converted back to draft. I was considering it ready for merging/testing, but noticed something else in between that I need to clean up. Will you be testing this (testing closet, etc) from this branch or you intend to merge it first? Everything works fine from TESTING, I will redo all tests again, before making it ready. Will also post the release checklist here, as soon as I finish it and then make it ready for review. |
I'll test before merging this. |
I pushed my two changes. I will re-do the release checklist tomorrow. If you want to test it today, you can flash the latest build. |
test_onroad result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some additional services that fail, but can be disabled.
Some tools like nvme (e.g. nvme list) and i2cdetect dont work, because the newer cli versions require an updated kernel. They are not strictly necessary, but probably still nice to have. |
Good catch, didn’t test The |
nvme needs sudo in 20.04 and should work there. But probably ok to keep as is at it'll be fixed with the newer kernel. |
EDIT:
indeed it works with a NVME drive in C3 |
To clear this out, even if
|
Apart from the size increase, from my point of view, it's ready for testing. I'm still pending the tests that need factory resets. Doing them asap. I'm writing a separate comment to what I'm proposing to reduce the size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glanced over and looks like there's still a bunch of TODOs and commented out stuff. Can you do a pass through all that and make sure everything's resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final things to do before merging:
- testing closet validation, already started @adeebshihadeh
- instructions for rest of debs @andiradulescu
- push the debs to LFS @adeebshihadeh
- check the systemd service diff @adeebshihadeh
done
agnos-builder is on GitHub LFS - not GitLab LFS
good point, 160 loaded units listed in 24.04 vs 20.04: * there is a nice addition like systemd-repart.service and some services that we should disable (like TPM2 PCR * and others) |
the build is fixed now (with rebuilt debs). just systemd services disable is pending, will do it tomorrow. |
EDIT: fixed |
Co-authored-by: Robin Reckmann <robin.reckmann@gmail.com>
✅ AGNOS update 2404-2 readyIn an openpilot branch, download agnos.json in For flashing locally, download and unarchive the images in Images: |
Part of commaai/openpilot#32386
Release Checklist
test_onroad
passespython
is our python, not system versionscons -c && scons -j8
ABL
XBL
Setup
Networking
Custom URL
comma
,abc123
,...
)github.com
,comma.ai
,installer.comma.ai
)openpilot.comma.ai
)/tmp/installer_url
should contain the installer URL