-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build independent packages first #354
Build independent packages first #354
Conversation
What does this improve? I generally find splitting up Dockerfiles to be pretty annoying since you have to manage each separately. |
Ok, so then I would move the compiler part to the top of the existing Dockerfile. |
✅ AGNOS update 11-8785203 readyIn an openpilot branch, download agnos.json in For flashing locally, download and unarchive the images in Images:
Stats:
|
Compile time test: #359 |
Also shared this on Discord - I would create "agnos-base" from the tar.gz file instead of "ubuntu:24.04". God knows what differences might be (now or in the future) between them. It shouldn't affect the compiled deb files, though, just trying to be safe. @adeebshihadeh what do you think? Besides this, LGTM! |
I dont have a strong preference, which base to use. I compared the compiled binaries and they are identical with the ones generated with current master. "agnos-base" is still using the tar.gz. Only the compiler is user docker ubuntu |
Move package compilation to the beginning of the main dockerfile. This parts can now run in parallel to the main installation up until the compiled packages are installed.