Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build independent packages first #354

Merged
merged 20 commits into from
Sep 11, 2024

Conversation

robin-reckmann
Copy link
Contributor

@robin-reckmann robin-reckmann commented Sep 7, 2024

Move package compilation to the beginning of the main dockerfile. This parts can now run in parallel to the main installation up until the compiled packages are installed.

@robin-reckmann robin-reckmann marked this pull request as draft September 7, 2024 15:25
@robin-reckmann robin-reckmann marked this pull request as ready for review September 8, 2024 14:47
@adeebshihadeh
Copy link
Contributor

What does this improve? I generally find splitting up Dockerfiles to be pretty annoying since you have to manage each separately.

@robin-reckmann
Copy link
Contributor Author

robin-reckmann commented Sep 9, 2024

What does this improve? I generally find splitting up Dockerfiles to be pretty annoying since you have to manage each separately.

Ok, so then I would move the compiler part to the top of the existing Dockerfile.

@robin-reckmann robin-reckmann changed the title Move package compilation to separate dockerfile Move package compilation to the top of the dockerfile Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

✅ AGNOS update 11-8785203 ready

In an openpilot branch, download agnos.json in system/hardware/tici/ and update AGNOS_VERSION to "11-8785203" in launch_env.sh.

For flashing locally, download and unarchive the images in agnos-builder/output and flash with ./flash_all.sh.

Images:

Stats:

3.7G	/
620M	/usr/local/venv
836M	/usr/lib/aarch64-linux-gnu
338M	/usr/lib/llvm-18
155M	/usr/lib/arm-linux-gnueabihf
323M	/usr/share
283M	/usr/bin
166M	/usr/comma

@robin-reckmann
Copy link
Contributor Author

Compile time test: #359
min/max/avg : 8m46s / 9m02s / 8m54s

@andiradulescu
Copy link
Collaborator

andiradulescu commented Sep 10, 2024

Also shared this on Discord - I would create "agnos-base" from the tar.gz file instead of "ubuntu:24.04". God knows what differences might be (now or in the future) between them.

It shouldn't affect the compiled deb files, though, just trying to be safe. @adeebshihadeh what do you think?

Besides this, LGTM!

@robin-reckmann
Copy link
Contributor Author

robin-reckmann commented Sep 10, 2024

I dont have a strong preference, which base to use. I compared the compiled binaries and they are identical with the ones generated with current master. "agnos-base" is still using the tar.gz. Only the compiler is user docker ubuntu

@adeebshihadeh adeebshihadeh changed the title Move package compilation to the top of the dockerfile Build independent packages first Sep 11, 2024
@adeebshihadeh adeebshihadeh merged commit f856a66 into commaai:master Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants