Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ford: add OP-style transmission values #590

Closed
wants to merge 1 commit into from

Conversation

incognitojam
Copy link
Member

@incognitojam incognitojam commented Apr 13, 2022

DBC updates to allow for parsing transmission gear in openpilot

Would it be preferred that I create a new DBC file with the OP relevant signals, so that I don't have to delete any of the original information?

@incognitojam incognitojam marked this pull request as ready for review April 14, 2022 00:10
@incognitojam
Copy link
Member Author

Also this DBC has duplicates for lots of signals with both VAL_ and VAL_TABLE_ statements... I'm not sure if that affects how OP parses it, but other brands just seem to use VAL_.

@adeebshihadeh
Copy link
Contributor

Hmm, this DBC is actually quite nice. I'm cool with leaving the Ford as is if you want.

@incognitojam
Copy link
Member Author

If you think so, that's fine with me 😄

@incognitojam incognitojam deleted the ford-parse-gear branch April 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants