-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move car.capnp to opendbc #33646
Labels
Comments
The approach of this PR is to move
This ensures that car.capnp can be imported properly without conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@deanlee interested in this? We want to replace the dataclasses with car.capnp again, but it can live in opendbc. The duplication of the structs is starting to get annoying and is error-prone if one place is forgotten to be updated.
There are some issues we need to resolve:
OnroadEventDEPRECATED
.Edit: I don't think so, you will get a duplicate ID error when you import both car.capnp in opendbc and the duplicate included one in log.capnp (from a symlink)
The text was updated successfully, but these errors were encountered: