move car.capnp to opendbc #33656
Closed
move car.capnp to opendbc #33656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI PreviewAll Screenshots
|
deanlee
force-pushed
the
car_move_car_capnp
branch
6 times, most recently
from
3790e4b
to
b4d9aaf
Compare
deanlee
force-pushed
the
car_move_car_capnp
branch
from
b4d9aaf
to
e32467a
Compare
deanlee
force-pushed
the
car_move_car_capnp
branch
from
e32467a
to
ce0c254
Compare
sshane
reviewed
Oct 1, 2024
|
Moved to #33722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related pr: commaai/opendbc#1288
resolve #33646
The differences in process replay results
might be due toare caused by replacing the dataclasses in structs.py with car.capnp, which reduced the precision of float fields from Python's 64-bit (double precision) to Cap'n Proto's 32-bit (we use Float32 for all float fields in car.capnp).